Labels readability [#1487744]

Hi, I use Rubik as a theme admin in all of my projects.

Here are a few things I keep re-doing every time. So here is a patch against last dev (Tao too) which make the following:

adds a theme setting which allows to disable the right side bar in forms,
improves Status report alignment for .merge-down and .merge-up rows (think Cron + description line),
removes uppercase CSS transform for labels and breadcrumb*.

Hope to see this included in Rubik. By the way thanks for the great work. :-)

* this is personal consideration, but I found that transforming to uppercase removes information in some contexts and more importantly
makes strings more complicated to read. If letters have different heights there must be a reason.

Comment	File	Size	Author
#9	label-readability-and-disable-sidebar-1487744-9.patch	8.05 KB	kyletaylored
#6	Label-Readability-and-Disable-Sidebar-1487744-6.patch	6.42 KB	kyletaylored
#3	Label-Readability-and-Disable-Sidebar-1487744-3.patch	6.24 KB	kyletaylored
	sidebar_css.diff	5.25 KB	jchatard

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jchatard CreditAttribution: jchatard commented 17 March 2012 at 14:34

Oops title is not relevant, but can't edit it :-)

Comment #2

haydeniv CreditAttribution: haydeniv commented 23 November 2013 at 05:26

Issue summary:	View changes
Status:	Needs review	» Needs work

This needs a re-roll. It does not apply in the current dev. Thanks.

Comment #3

kyletaylored CreditAttribution: kyletaylored commented 11 January 2014 at 04:17

File	Size
Label-Readability-and-Disable-Sidebar-1487744-3.patch	6.24 KB

Rerolled and renamed the theme setting to something more appropriate.

Comment #4

kyletaylored CreditAttribution: kyletaylored commented 11 January 2014 at 04:18

Status:

Needs work

» Needs review

Comment #5

haydeniv CreditAttribution: haydeniv commented 14 January 2014 at 07:27

Status:

Needs review

» Needs work

```
+++ b/core.css
@@ -46,6 +46,13 @@ div.status {
+  padding: 0 18px;
```
This should probably be padding: 0 40px;

That way it lines up with the rest of the lines and will still work if we add icons to the status report.
Look at the status report to see the issue.
```
+++ b/rubik.info
@@ -19,3 +19,5 @@ stylesheets[print][] = print.css
+settings[rubik_disable_sidebar_in_form] = 0
```
Maybe it is just mine but I checked the box for the disable setting and it appears to have done nothing.
Edit: I see the problem. You have to clear the cache for that to actually change the setting. We should probably try and trigger a theme registry rebuild when those settings are changed.

Comment #6

kyletaylored CreditAttribution: kyletaylored commented 16 March 2014 at 14:29

File	Size
Label-Readability-and-Disable-Sidebar-1487744-6.patch	6.42 KB

2 files were hidden/shown/deleted

File	Size
sidebar_css.diff	5.25 KB
Label-Readability-and-Disable-Sidebar-1487744-3.patch	6.24 KB

I re-rolled the patch. Added some padding, also increased the font on those descriptions just a tad for accessibility, they were pretty small on my screen. I also added a theme registry rebuild after saving the theme settings, so you can see the changes immediately.

Comment #7

kyletaylored CreditAttribution: kyletaylored commented 16 March 2014 at 14:31

Status:

Needs work

» Needs review

Comment #8

haydeniv CreditAttribution: haydeniv commented 17 March 2014 at 05:55

Status:

Needs review

» Needs work

This does not apply now that #1626886: Make sidebar sticky and add sidebar field option is in.

Comment #9

kyletaylored CreditAttribution: kyletaylored commented 17 March 2014 at 06:47

File	Size
label-readability-and-disable-sidebar-1487744-9.patch	8.05 KB

Re-rolled with current dev and added some checks for when the sidebar is disabled to not conflict with #1626886: Make sidebar sticky and add sidebar field option.