Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When running drush make with libraries set as the following, the file is named wrongly.
libraries[autopager][download][type] = "get"
libraries[autopager][download][url] = "http://lagoscript.org/files/jquery/autopager/jquery.autopager-1.0.0.js"
libraries[autopager][directory_name] = "autopager"
The file is put in the correct folder but with name as http---lagoscript.org-files-jquery-autopager-jquery.autopager-1.0.0.js
which causes the library to don't load correctly.
Comment | File | Size | Author |
---|---|---|---|
#5 | drush-1490714-05-single-file-name-issue.patch | 1.86 KB | jhedstrom |
Comments
Comment #1
jhedstromI think you need to specify the 'filename' attribute:
libraries[jquery.cycle][download][filename] = "jquery.cycle.js"
Comment #2
jhedstromComment #3
recidive CreditAttribution: recidive commented@jhedstrom: ok, but drush make 4.x was assigning the original library file name, not a "sanitized" version of the URL. I thought this was a regression that could be fixed easily.
Comment #4
jhedstrom@recidive, you're right--in this case it should default to the name 'jquery.autopager-1.0.0.js' without having to specify that. I misunderstood the initial issue. Looking into this now.
Comment #5
jhedstromThis fixes the issue for me. Posting for review, but will commit soon. Also added a test so this doesn't break again (it was the subtree patch that caused this issue).
Comment #6
jhedstromDecided to just commit since all tests are still passing. Fixed in 87d2dad.