Hello, I got some time to work on UUID/Deploy integration for Bean module. I would like to know if this is accepted as a patch or if this should be a separated module/project.

It basically needs an uuid field added to schema and a couple hook implementations.

CommentFileSizeAuthor
#4 1491956.patch2.8 KBrecidive
#2 1491956.patch2.7 KBrecidive
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

indytechcook’s picture

Go ahead and submit the patch then I'll let you know if it should be in a separate module.

recidive’s picture

Status: Active » Needs review
FileSize
2.7 KB

I talked briefly with @indytechcook on IRC and we figured out this is better as a separate module but same project, since Bean module can't depend on UUID.

Attached is an initial patch implementing some UUID/Deploy support. It looks like some UI work is necessary for adding the Bean blocks to a deploy plan, I still need to figure this out.

skwashd’s picture

Status: Needs review » Needs work

Overall this looks good. One quick comment.

+++ b/bean_uuid/bean_uuid.installundefined
@@ -0,0 +1,31 @@
+  db_add_index('bean', 'uuid', array('uuid'));

I think you need a uuid_sync_all() call after this to populate the UUIDs for BEAN

recidive’s picture

Status: Needs work » Needs review
FileSize
2.8 KB

Ok, I added uuid_sync_all() to hook_enable() instead, since this cover the case when the module is disable for a period of time and then enabled again.

indytechcook’s picture

Thanks recidive, it looks good to me.

I'm inclined to commit this especially since it's passive. I'd like someone else to review before I do.

skwashd’s picture

Status: Needs review » Reviewed & tested by the community

I applied #4 against current HEAD (49b390c50fae6e5aa1a051d127902ccd4689d0de) it applied cleanly and works well.

Disclaimer: I work for the same company as @recidive.

indytechcook’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.