Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello, I got some time to work on UUID/Deploy integration for Bean module. I would like to know if this is accepted as a patch or if this should be a separated module/project.
It basically needs an uuid field added to schema and a couple hook implementations.
Comment | File | Size | Author |
---|---|---|---|
#4 | 1491956.patch | 2.8 KB | recidive |
#2 | 1491956.patch | 2.7 KB | recidive |
Comments
Comment #1
indytechcook CreditAttribution: indytechcook commentedGo ahead and submit the patch then I'll let you know if it should be in a separate module.
Comment #2
recidive CreditAttribution: recidive commentedI talked briefly with @indytechcook on IRC and we figured out this is better as a separate module but same project, since Bean module can't depend on UUID.
Attached is an initial patch implementing some UUID/Deploy support. It looks like some UI work is necessary for adding the Bean blocks to a deploy plan, I still need to figure this out.
Comment #3
skwashd CreditAttribution: skwashd commentedOverall this looks good. One quick comment.
I think you need a uuid_sync_all() call after this to populate the UUIDs for BEAN
Comment #4
recidive CreditAttribution: recidive commentedOk, I added uuid_sync_all() to hook_enable() instead, since this cover the case when the module is disable for a period of time and then enabled again.
Comment #5
indytechcook CreditAttribution: indytechcook commentedThanks recidive, it looks good to me.
I'm inclined to commit this especially since it's passive. I'd like someone else to review before I do.
Comment #6
skwashd CreditAttribution: skwashd commentedI applied #4 against current HEAD (49b390c50fae6e5aa1a051d127902ccd4689d0de) it applied cleanly and works well.
Disclaimer: I work for the same company as @recidive.
Comment #7
indytechcook CreditAttribution: indytechcook commentedThis is commited.
http://drupal.org/commitlog/commit/22232/5d810f29738408dd09d01ba1455a286...