The attached patch removes an unused setting of the variable $http_protocol and tidies up another use of the variable. No functional changes.

Files: 
CommentFileSizeAuthor
#11 1494676-remove_unused_http_protocol.patch430 bytescam8001
PASSED: [[SimpleTest]]: [MySQL] 39,578 pass(es).
[ View ]
#7 http_protocol.patch450 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 42,306 pass(es).
[ View ]
#4 http_protocol.patch782 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 42,122 pass(es).
[ View ]
#3 http_protocol.patch782 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 37,294 pass(es).
[ View ]
#2 http_protocol.patch782 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 35,674 pass(es).
[ View ]
http_protocol.patch780 bytesLiam Morland
FAILED: [[SimpleTest]]: [MySQL] 35,652 pass(es), 15 fail(s), and 4 exception(s).
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, http_protocol.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new782 bytes
PASSED: [[SimpleTest]]: [MySQL] 35,674 pass(es).
[ View ]

StatusFileSize
new782 bytes
PASSED: [[SimpleTest]]: [MySQL] 37,294 pass(es).
[ View ]

Updated patch rolled against latest D8.

StatusFileSize
new782 bytes
PASSED: [[SimpleTest]]: [MySQL] 42,122 pass(es).
[ View ]

Reroll.

Status:Needs review» Reviewed & tested by the community

Looks good to me and passes the bot!

Status:Reviewed & tested by the community» Needs work

+++ b/core/includes/bootstrap.incundefined
@@ -743,8 +742,7 @@ function drupal_settings_initialize() {
+    $base_root = ($is_https ? 'https' : 'http') . '://' . $_SERVER['HTTP_HOST'];

While this is technically valid PHP to throw a ternary operation in the middle of a string, it's a little strange compared to what we do elsewhere. I actually find the former code a bit easier to read. :\

I would recommend just a patch to get rid of the bunk variable in the if ($base_url) check alone.

Status:Needs work» Needs review
StatusFileSize
new450 bytes
PASSED: [[SimpleTest]]: [MySQL] 42,306 pass(es).
[ View ]

OK, see attached.

Status:Needs review» Reviewed & tested by the community

Looks good to me. I was just about to post this exact patch.

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Issue tags:+Novice

Adding tags.

Version:8.x-dev» 7.x-dev
Status:Fixed» Needs review
StatusFileSize
new430 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,578 pass(es).
[ View ]

Here's a quick backport.

Status:Needs review» Reviewed & tested by the community

Looks good. Thanks.

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.