Videojs 3.1.0.

As described in my comments at http://help.videojs.com/discussions/problems/1045-could-not-work-in-ie9-... I have found that creating DOM nodes manually using a specified node name of 'video' and 'source' breaks videojs, because the node literally has the nodeName value of 'video' and 'source', and in at least two places video.js tests with "== 'SOURCE'".

This leads to the options.sources variable being an empty array, leading to incorrect setup and, at least, the flash fallback loading but then failing with ugly "src not found" errors.

I would suggest that assuming nodeName to be uppercase is incorrect, and suggest changing the tests from:

c.nodeName == "SOURCE"

to

c.nodeName.toLowerCase() === "source"

Do you need me to provide a test page or can you take my word for it?

I'm assigning this bug report to "Version" 7.2-2.x-dev .. I assume those version numbers are Drupal version numbers and have no relevance at all to the videojs version.

Comments

Jorrit’s picture

Jorrit CreditAttribution: Jorrit commented
Status: Active » Closed (won't fix)

Unfortunately, this bug tracker is just for the Drupal module and I believe that the code change you are suggesting is related to library code, not Drupal code. The Video.js bugtracker is https://github.com/zencoder/video-js/issues , but the number of open issues and pull requests suggest that the library isn't maintained regularly.

neekfenwick’s picture

neekfenwick CreditAttribution: neekfenwick commented

Gah, you're right Jorrit, thank you. I googled onto this and it didn't feel right at all.