Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Just updated to 7.x-3.2 and notices that all the Titles in my custom blocks disappeared. It seems that Panels doesn't fetch the block title from the Blocks module as it has done in previous versions. I solved the problem by going back to 3.1. I don't have the coding skills to fix the problem. Just wanted you guys to know the problem and that it needs some review.
Comment | File | Size | Author |
---|---|---|---|
#12 | 1505224-12-blocks_titles_are_dumb.patch | 747 bytes | gavin.hughes |
Comments
Comment #1
Cyclodex CreditAttribution: Cyclodex commentedI can confirm this. After update, the title seems to be missing.
I re-saved the block & panels but does not help.
drush cc all
of course too.When I add a custom title in the panel settings of the block, the title is shown, but when I leave it empty or even when I try to use the %title it will not be shown.
Comment #2
darthf1 CreditAttribution: darthf1 commentedConfirming this issue.
Drupal 7.12
Panels 7.x-3.2
Comment #3
jenlamptonThis looks like it may be a problem with core, block_block_view will never get a block title:
and panels checks to see if the block title is set (even though it will always be NULL) after invoking block_view:
It looks like the only place block module actually retrieves the block title, is in _block_load_blocks
So we may have to add our own query here to get the block title. I would love some more eyes on my DBTNG and please test the patch :)
Comment #4
merlinofchaos CreditAttribution: merlinofchaos commentedArgh. We used to have our own version of _block_load_blocks().
Did that get ruined in the i18nblocks compatibility back and forth?
Comment #5
JSCSJSCS CreditAttribution: JSCSJSCS commented#3 worked for me so far. Thanks for posting!
Comment #6
Cyclodex CreditAttribution: Cyclodex commentedYes the #3 works, but I just found out that this could be related to the ctools change, perhaps we should move this over to ctools issue list?
I analysed problems I had with translation of blocks. The are not translated anymore since ctools 7.x-1.0 Release
I reverted some of the changes between RC1 and final release, which gave me both things back:
So I wanted to link this thread.
Hope I could help a bit, I do not understand everything yet...
Comment #7
Hanpersand CreditAttribution: Hanpersand commentedWhat's the status of this? Is that patch getting added back into Panels? Just wondering.
Comment #8
jhuon CreditAttribution: jhuon commentedIt looks like the patch has been added but I still have problems to see my title. The only way to display my title correctly is to override it with plain text. I can't use the %title replacement either.
Comment #9
merlinofchaos CreditAttribution: merlinofchaos commentedI'm pretty sure the latest CTools has this all fixed; at least, it seems to now work in my testing.
Comment #11
RogerRogers CreditAttribution: RogerRogers commentedJust FYI, I had to apply this patch to the latest ctool dev release that I pulled today.
Comment #12
gavin.hughes CreditAttribution: gavin.hughes commentedI think this issue is still active, I had to apply patch against 7.x-3.3, and patch works! although I did make a change to the patch to use a relative path, so i'v attached that.
Comment #13
kenorb CreditAttribution: kenorb commentedComment #16
andrewmacpherson CreditAttribution: andrewmacpherson commentedNot sure why this patch was in the Panels issue queue - it actually changes a file in ctools.
Moving to correct project, re-setting to needs review.
Comment #17
andrewmacpherson CreditAttribution: andrewmacpherson commentedFor some reason I can't select the version.
Patch applies cleanly to ctools-7.x-1.7
Comment #19
drummComment #20
jenlamptonPatch in #12 still applies cleanly to ctools 7.x-1.9.
Comment #21
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 5 year old patch in #12 to block.inc applied cleanly to the latest ctools 7.x-1.x-dev and (if still applicable) needs review.