Although not technically (external) social media, I believe the site RSS feed icon would be nice to have along with the FB, Twitter, Google+ icons etc.

It would be convenient to allow the user to specify a feed URL in the corresponding screen, in a similar fashion to the follow module.

Thank you

Comments

dddave’s picture

That would be pretty cool!

TomDude48’s picture

Status: Active » Needs review

I added this to the latest dev release. You can specify a default RSS feed or add multiple rss buttons and specify a feed for each one.

marktheshark’s picture

Thanks, I'll take a look and get back to you.

dddave’s picture

Seems to be working fine. Thanks!

areikiera’s picture

Hello! Thanks for adding the RSS option! I had a couple questions, and possibly a feature request if there's not a way around it.

On the default widget set 'socialmedia_profile-default', the RSS icon code is output like this:

<a target="_blank" title="Subscribe to via RSS" href="/blog.xml">
<img alt="SlideShare icon" src="/sites/all/modules/socialmedia/icons/levelten/glossy/48x48/rss.png">
</a>

2 things:

  1. In line 215 of 'socialmedia.widgets.inc', the Feed Name is being referenced to be inserted into the link 'title' which should output "Subscribe to FEED NAME via RSS". Where can I specify the Feed Name?
  2. Also, the image 'alt' text reads "Slideshare Icon" instead of "RSS Icon". I fixed this by editing the 'alt' text in line 215 of 'socialmedia.widgets.inc'. Not experienced at creating patches, I'm afraid. *EDIT: this change didn't fix it, but I'm not sure why. Cleared cache, but the widget block doesn't seem to want to update. Any suggestions?

Thanks for any guidance! I can create a new issue if this should be reported separately. Just let me know!

areikiera’s picture

Version: 7.x-1.x-dev » 7.x-1.0-beta11
Status: Needs review » Needs work

Updating to 'Needs work' for the issues mentioned above, and changing version to beta11.

TomDude48’s picture

Status: Needs work » Needs review

areikiera,

I changed the alt text. As far as changing the feed name. You can go to the Widgets admin, edit the widget set and select the RSS widget to edit. The edit form will allow you to edit the feedname. Note: you will probably need to override the widget set to make changes.

marktheshark’s picture

Hello again,

Thanks for implementing this feature request.

I would like to make an additional recommendation:

Currently the module allows the admin to specify one feed location, however some people may have different feeds per language. For instance /rss.xml is my default language feed, but /en/rss.xml is the English feed. Per current design, selection of the correct language does not work properly.

  • If I set the feed to /rss.xml, only the default RSS feed is linked to by the icon, regardless of site language.
  • If I set the feed to rss.xml (no leading /), the path is evaluated relative to the current path. English feed is shown only if you happen to be inside a /en/something path.

My suggestion would be to evaluate the RSS path always as relative to the site root (as is done for menus) and pass the link to the 'l' function which I believe handles the language automatically.

Thank you

TomDude48’s picture

I have added a call using the url function. I don't have a multi language setup right now. Can you verify this fixes the issue.

lsolesen’s picture

Status: Needs review » Needs work

The rss feed icon is added even when no rss feed has been specified, e.g. for users. Therefore it still needs work.

sjhuskey’s picture

Just reporting that the issue mentioned in #5 above where the site name doesn't show up in the title of the link is still not resolved. I had to just change the code in socialmedia.widgets.inc from this:

$stitle2 = t("Subscribe to !varfeedname via RSS", array('!varfeedname' => '[?profile_username=[socialmedia:sm-rss_feedname]?]'));

to this:

$stitle2 = t("Subscribe to MYFEEDNAME via RSS");

That will break if there's an update to the module, of course, but I don't know what else to do. Suggestions?