Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Our subversion repository has pre-commit hooks to prevent code being committed with PHP errors. When I tried to commit this module I got:
Parse error: syntax error, unexpected T_ELSE in
drupal/trunk/modules/contrib/advagg/advagg_css_compress/csstidy/class.csstidy.inc
on line 1028
Looking at the code it looks like the else is in the wrong place:
while (isset($this->css[$media])) {
if (is_numeric($media)) {
$media++;
}
}
else {
$media .= " ";
}
Comment | File | Size | Author |
---|---|---|---|
#1 | advagg-1507332-1-fix-parse-error.patch | 460 bytes | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedLame. Auto coder upgrade screwed up in this case. http://drupal.org/node/1285886#comment-5772944
What the code looked like before... can't really blame it as this is just bad PHP programing yet valid python. http://drupalcode.org/project/advagg.git/blob/5c4c963d1325467b6ccb2e1807...
The following patch has been committed. Just tested all 3rd party addons and they seem to be fine.