Our subversion repository has pre-commit hooks to prevent code being committed with PHP errors. When I tried to commit this module I got:

Parse error: syntax error, unexpected T_ELSE in
drupal/trunk/modules/contrib/advagg/advagg_css_compress/csstidy/class.csstidy.inc
on line 1028

Looking at the code it looks like the else is in the wrong place:

    while (isset($this->css[$media])) {
      if (is_numeric($media)) {
        $media++;
      }
    }
    else {
      $media .= " ";
    }
CommentFileSizeAuthor
#1 advagg-1507332-1-fix-parse-error.patch460 bytesmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

Status: Active » Fixed
FileSize
460 bytes

Lame. Auto coder upgrade screwed up in this case. http://drupal.org/node/1285886#comment-5772944
What the code looked like before... can't really blame it as this is just bad PHP programing yet valid python. http://drupalcode.org/project/advagg.git/blob/5c4c963d1325467b6ccb2e1807...

The following patch has been committed. Just tested all 3rd party addons and they seem to be fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.