Similar to Devel module's #1263514: patch to notify (likely technical) user what (svn-command) failed in `drush en devel` - show copy of the exec

If svn isn't installed, you get a pretty generic error:

Drush was unable to download CKEditor to /var/www/sites/all/libraries/ckeditor.

First thought to fix was permisssions, after all how often does installing subversion solve the problem? :P

The devel patch above shows the failed exec line which would help in debugging.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dczepierga’s picture

Status: Active » Needs review
FileSize
1.5 KB

I make patch for it - pls apply this patch to last DEV version and check does it work or nor for u.

Greetings

mkesicki’s picture

Assigned: Unassigned » dczepierga
dczepierga’s picture

Title: 'drush ckeditor-download' fails if svn not installed » [D7] 'drush ckeditor-download' fails if svn not installed
Status: Needs review » Fixed

Changes commited to GIT (diff).

Greetings

mkesicki’s picture

Status: Fixed » Closed (fixed)
yaach’s picture

This is still a problem on 7.x-1.19.

vokiel’s picture

Assigned: dczepierga » vokiel
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
5.09 KB

Using SVN won't work as we're not updating it anymore.

I've changed the code responsible for downloading CKEditor. Now it downloads archive from the https://download.cksource.com/CKEditor/CKEditor/ website.

No need to have SVN, GIT installed on the server. Untar is handled by the Drush internal commands.

solideogloria’s picture

The patch file contains the same patch twice (so it doesn't apply). Also it doesn't follow Drupal coding standards.

Attached is a working/fixed patch. Download using the command works.

vokiel’s picture

Thank you.

Attaching another patch with your suggestions. Removed the not needed else part as in my initial patch.

solideogloria’s picture

Status: Needs review » Reviewed & tested by the community

  • vokiel committed 0684910 on 7.x-1.x
    Issue #1507852 by vokiel, solideogloria, dczepierga: [D7] 'drush...
vokiel’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.