Allow null fields to be tampered with [#1508584]

If a field is imported as null (i.e. with feeds xpath parser for an xml node that is missing an element) feeds tamper will skip tampering the field. It would be nice to allow these fields to be tampered anyway.

Patch to follow.

Comment	File	Size	Author
#1	1508584-1-feeds_tamper-allow_null_tamper.patch	749 bytes	elliotttf
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

elliotttf CreditAttribution: elliotttf commented 29 March 2012 at 17:49

Status:

Active

» Needs review

File	Size
1508584-1-feeds_tamper-allow_null_tamper.patch	749 bytes

Comment #2

chrisroditis CreditAttribution: chrisroditis commented 6 April 2012 at 19:53

Works wonderfully!

Comment #3

twistor CreditAttribution: twistor commented 6 April 2012 at 21:41

Status:

Needs review

» Needs work

I'm not sure this is desirable in all cases. I know from experience that something is needed though.

There's actually two different use cases here. Tampering NULL, which would be the following patch. This is going in either way:

     foreach ($importer_instances as $element_key => $instances) {
-      if (isset($item[$element_key])) {
+      if (array_key_exists($item[$element_key])) {
         foreach ($instances as $instance) {
           $plugin = $plugins[$instance->plugin_id];
           $is_array = is_array($item[$element_key]);

Then there's setting the field to NULL if it was unset. This is also needed, but sometimes it is undesired.

Comment #4

elliotttf CreditAttribution: elliotttf commented 20 April 2012 at 15:35

I believe the original patch achieves both cases. The reason isset and array_key_exists were both used was to short circuit the conditional with the more performant isset if the null case wasn't needed.

I agree that there may be cases where setting the field to null might be undesirable but I haven't personally hit one of those cases yet. If someone can chime in with a use case where that'd be a bad idea I'd be happy to bounce around some other ideas.