Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It looks like #1490090: Replace direct cp, ls and mv calls with drush_copy_dir, drush_scan_directory and drush_move_dir broke #919224: Allow use of subtrees or individual file from archives instead of the whole archive
While testing #1482888: Support 'subtree' download attribute for libraries it became apparent that drush was no longer moving subtree directives properly.
Looks like we need some additional tests to catch this issue, and/or the existing test needs some refactoring. Fullcalendar may be a good additional test case;
libraries[fullcalendar][download][type] = get
libraries[fullcalendar][download][url] = http://arshaw.com/fullcalendar/downloads/fullcalendar-1.5.3.zip
libraries[fullcalendar][download][sha1] = c7219b1ddd2b11ccdbf83ebd116872affbc45d7a
libraries[fullcalendar][download][subtree] = fullcalendar
Comment | File | Size | Author |
---|---|---|---|
#3 | drush-make-1514120-03.patch | 2.03 KB | jhedstrom |
#2 | drush-make-1514120-01.patch | 1.29 KB | jhedstrom |
Comments
Comment #1
jhedstromThis is starting to feel like whack-a-mole. Definitely want better test coverage of this subtree stuff.
Comment #2
jhedstromThis patch highlights the regression. I checked out revision 87d2dad8c, which is where the subtree option was first introduced, and verified that this patched subtree.make file builds properly. Using the latest master it fails. My guess is that #1490090: Replace direct cp, ls and mv calls with drush_copy_dir, drush_scan_directory and drush_move_dir had something to do with the breakage, and the previous subtree.make file wasn't complete enough to catch the problem.
Comment #3
jhedstromThis patch fixes the issue. The problem was a simple oversight in #1490090: Replace direct cp, ls and mv calls with drush_copy_dir, drush_scan_directory and drush_move_dir which dropped subtree support in one of the 2 places its used.
Going to commit this shortly.
Comment #4
jhedstromCommitted in 24f4bc8. Thanks for finding this issue jgraham!
Comment #5
jgraham CreditAttribution: jgraham commentedAwesome tested and looks great thanks jhedstrom :)