This is a cosmetic change in followup of #1338282: Fix php notice in menu_link_save().
Current code
if (!$existing_item || (array_intersect_key($item, $existing_item)) != $existing_item)
has meaningless parenthesis around array_intersect_key().
This should be changed to
if (!$existing_item || (array_intersect_key($item, $existing_item) != $existing_item))
(suggested patch) or
if (!$existing_item || array_intersect_key($item, $existing_item) != $existing_item)
All three variants are syntactically equivalent, yet the second one suggests self-explaining order of operations

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

valthebald’s picture

Status: Active » Needs review
Issue tags: +Novice
FileSize
761 bytes
xjm’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

Dries’s picture

Version: 8.x-dev » 7.x-dev

Committed to 8.x. Moving to 7.x.

rdickert’s picture

Assigned: valthebald » rdickert
Status: Reviewed & tested by the community » Patch (to be ported)

Taking this issue for backport.

rdickert’s picture

Status: Patch (to be ported) » Needs review
FileSize
741 bytes

Backported to D7.

valthebald’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

cweagans’s picture

Issue tags: +Needs backport to D7