Admin menu is one of the recommended modules appearing on the Commerce project page, and a long time favorite module of mine (thank you!) but we ran into a issue of the combination of both on a recent project.

Commerce requires Rules UI for it's Tax, Tax UI, and Cart Modules. Apparently Rules UI as part of the GUI for their shopping cart. (I spoke with one of their team and there's a plan to remove Rules UI dependency but is isn't going to happen very soon)

I was on a client's live site and enabled views UI to do a minor tweak and then hit. "Disable Development modules" when done. Predictably it disabled Rules UI, but didn't care about modules depending on it (commerce cart). So unfortunately the shopping cart and gave a white screen of death when you checkout.

Here's my proposed feature request. When a user clicks "Disable Development modules" - Check to see if the modules getting disabled have any dependencies. If they do add a dialogue notification. "Are you sure? Module(s) X,Y, and Z require Rules UI"

Also anyone else running into this problem the solution is simply to remove Rules UI from the list of modules disabled by admin menu in admin menu settings. "Developer modules to keep enabled " Check Rules UI.

CommentFileSizeAuthor
#4 1516574-remove_rules_admin-6794318.patch315 bytesbricel
#2 admin_menu_disable_dev_modules_result.png192.08 KBjoshbotnet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thetechguide’s picture

thetechguide CreditAttribution: thetechguide commented
Version: 7.x-3.0-rc1 » 7.x-3.0-rc3
Category: feature » bug

I am using 7.x-3.0-rc3 of the Admin module, 7.x-1.2 of the devel module and 7.x-2.1 of the Rules UI module. I can confirm that when using the Admin Module to "disable devel modules" the rules UI module and any modules dependent on rules UI are also disabled along with devel and theme developer modules. As many of the commerce modules are dependent on rules UI, they are also disabled which of course breaks your site until you figure out to enable all the impacted modules again. Temporary fix of course is to manually disable the devel modules when finished with them instead of using the admin menu option to disable the modules.

joshbotnet’s picture

joshbotnet CreditAttribution: joshbotnet commented
FileSize
admin_menu_disable_dev_modules_result.png192.08 KB

yep - see screenshot for example of modules (mainly commerce-related) switched off by Admin menu > Disable developer modules

seems you can avoid this via the "Developer modules to keep enabled" option at /admin/config/administration/admin_menu by keeping the UI-type modules switched on

disable dev modules - result

bricel’s picture

bricel CreditAttribution: bricel commented

Yes, this is a pretty dangerous behavior, since it's unexpected, and will break all commerce sites.
I think rules_admin should be removed from the list of modules disabled with this function.

bricel’s picture

bricel CreditAttribution: bricel commented
Status: Active » Needs review
FileSize
1516574-remove_rules_admin-6794318.patch315 bytes

See attached patch.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Issue summary: View changes
Status: Needs review » Closed (duplicate)
Related issues: +#1996082: "Disable Developer Modules" needs a confirmation

There should be a more generic way then remove this one module. Lots of sites won't have this problem, but will have problems with other modules.
See[#1996082] for a more generic approach