Authentication; less verbose logging option [#1517860]

In my setup, I have 3 AD servers. Most users authenticate to the first immediately, but a few use the others. If a user authenticates to the first, about 5 messages are logged to the DB log. If a user's credentials are incorrect or they use the last server, about 15 messages are logged. It seems like all of these messages could be combined to one or two per authentication server. It's not really a big problem since the messages are small and DB logging is cheap, but it would be nice for them to be more concise. If I have some time, I'm going to look into the code for this and hopefully come out with a patch, but I'm not sure if I will get to that.

Comments

Comment #1

johnbarclay CreditAttribution: johnbarclay commented 6 April 2012 at 15:21

This patch would be very welcomed. The user module logon really should take care of all the logging for a successful logon just as when a non ldap user logs in. There should only be one entry.

Anything else is excessive unless someone is debugging logons. And if someone needs a lot of logging for debugging, they can enable ldap_help and detailed logging.

Comment #2

johnbarclay CreditAttribution: johnbarclay commented 3 November 2012 at 13:32

Assigned:

Unassigned

» johnbarclay

Comment #3

johnbarclay CreditAttribution: johnbarclay commented 3 November 2012 at 18:53

Status:

Active

» Fixed

I disabled some of the common logging items when detailed logging is disabled. Am open to suggestions, but most of the watchdog calls are either errors or creation and deletion of ldap or drupal users which I feel should be logged based on what Drupal core logs. This is committed to 7.x-2.x-dev.

Here's the commit: http://drupalcode.org/project/ldap.git/commitdiff/refs/heads/7.x-2.x