Instead of the DS default being that all fields to start off as disabled that they start off with the same display settings as set on the Default Build Mode on the Manage Display page that may have been set prior to enabling DS.

The case is that everything may have been previously setup and working fairly well until a new client request comes in requiring some DS Rx (maybe simply a single change to one field). As written, enabling DS would require completely rebuilding the entire display settings for all the fields (possibly dozens) instead of enabling DS, choosing a new build mode that pulls the existing display settings as default and simply altering that single field's setting.

This request is to have DS use the Default Display/Build Mode settings as it's initial starting point for field display settings on a new Display/Build Mode...that is if this is actually done by DS and not something actually handled by Core or some other obfuscated process.

This is an offshoot of a similar request placed against the 6.x branch earlier (#1222946: Auto reordering of CCK field positions for Layout ...bad).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

There's a cloning feature, so this is pretty close to won't fix actually :)

DigitalFrontiersMedia’s picture

Status: Active » Closed (won't fix)

Ah. Thank you. Was just blindly following up from previous thread without even thinking about it. Cool. I don't see any other need then. So unless someone else disagrees, setting to closed (won't fix).

Thanks.

swentel’s picture

Also in D7, if you change a layout, you can select where fields in the current regions go into the new one (just like panels does), that makes switching laouts less harder.

greta_drupal’s picture

Clone doesn't in any way resolve the problem, that I see. It doesn't let you clone the core settings.

By the way, when I click Clone get this error (7.x-1.5):

Notice: Undefined index: node in field_group_field_ui_clone_field_groups() (line 782 of .../sites/all/modules/field_group/field_group.field_ui.inc).

swentel’s picture

That's a field group error.

As for the request. I understand the use case. We've talked this through at work several times and couldn't come up with a decent solution as we found many UI/UX/defaults problems. I'm always ready to review patches, but we're not planning to work on this.

greta_drupal’s picture

Not a module developer, but curiously: the module cannot read-in the core settings to prepopulate the Default build mode?

swentel’s picture

Reading those settings in is actually quite trivial. The clone method is not a lot of big code.
There's the UX challenge: In which region are we going to put them by default?

  • Only select one region and copy them.
  • Read in all core fields and move them into different regions.
  • Read in all fields (so core + all the ones that Display Suite will add) and move those to a region.

We've presented these options to a couple of people, and all want number 3 immediately - which is kinda obvious. Writing a decent UI for that is not easy. Checkboxes, select boxes, drag & drag (which would become ironic). We got stuck so we just left it like this, as it would take to many iterations for what we felt isn't that big of a deal, at least what we felt in our site building process.

greta_drupal’s picture

Well, if you'd like more input, here is mine:

My expectation would be for it to do no more (and no less) than core. For the Default, read in all core fields (with preserved states/settings) to a one-column layout, in the topmost region. I'd kiss you on the lips for that much. ...As long as the visibility, weight, and settings (such as for image) are preserved, it should be no different than the core UI and therefore cause me no additional work. It is very quick/easy to drag and drop those fields into different layout regions -- on that default or a clone of it. But, going through every one of them and reconfiguring -- at least 2 clicks for each (label, display) and more for settings like image -- is a nickle-dime time waster.

Applying chapstick now in anticipation of that (reasonable) functionality.

greta_drupal’s picture

Wouldn't even mind a patch for this, for now (against 7x-1.5 branch; or 7x-dev).

swentel’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Closed (won't fix) » Active

Ok, I'll give it a shot.

swentel’s picture

Status: Active » Needs review
FileSize
1.53 KB
2.49 KB

Ok, two patches for both branches. Patch for second branch actually fixes a small bug re: weights during rendering, so this is probably going to go in and the functionality is actually not *that* bad.

What it does is simply keeping the fields and their settings that are not hidden and move them into the first known region of the chosen layout. Let me know how it works out!

swentel’s picture

Hmm, it actually needs a small check for the comment field, but that's a trivial one.

greta_drupal’s picture

Wow! Quick response. I'll test it as soon as I can. Looks like I might need to buy more chapstick. (bisous)

swentel’s picture

Status: Needs review » Fixed

Committed this already :)

greta_drupal’s picture

Cool! I was just about to manually apply the patch. Is it commited to both 1.5 and -dev?

Oops. That was dumb. I install -dev. And report back about this addition.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

greta_drupal’s picture

Status: Closed (fixed) » Active

Sadly, this isn't working for 7.x-2.x-dev (2012-May-18). To which version
did you commit this? Dev, right? Did it get uncommitted or is it just not
working correctly?

PROBLEM:
Field order (weights) aren't respected.
Fieldgroup field nestings aren't respected.
Fieldgroups dumped to 'disabled' area.

Also getting tons of this error: http://drupal.org/node/1176454

Using latest dev of Field Groups - field_group 7.x-2.x-dev

PARTIAL (Kludgy) SUCCESS (?):
With custom fields created (no DS form display yet), I had to create a "throw-away" (since no config is preserved) DS display just to get a DS Default build -- no Default tab showing until a custom display is created. The weights and fieldgroups were pretty well respected for the Default. Saved. Then, added additional displays for Full Content and Teaser, and nothing was respected for those.

greta_drupal’s picture

FileSize
33.87 KB
39.93 KB

screenshots

swentel’s picture

Hmm yeah, didn't test this with field group at all. Note sure it's good to use the 7.x-2.x branch of field group though, should check with my colleagues.

greta_drupal’s picture

You didn't answer where the patch was committed. It isn't holding the field weights either, and that has nothing to do with Field Groups.

I am so freakin' overinvested (read: losing money) on this project, I'd settle for it working with any version of Field Groups. Using Display Suite is a huge time investment on this project. Plus, with every DS update, my layouts fall apart and I have to stop to try to "fix" them. Having to abandon it now will be heartbreaking.

With respect to field groupings, the DS project page states that DS does that. To be honest, since I have both DS and Field Groups installed, wasn't sure which was being used. Is there a DS version of grouping fields for display purposes? I'd be happy to try that instead.

aspilicious’s picture

Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

I see some additional changes in the current version regarding fieldgroup so I think this is fixed.

aspilicious’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)