Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
"This module has fallen behind the latest releases of Date module, there is a good amount of work to be done until it is stable again."
The issue queue is the correct place for dealing with this. @Tim - please elaborate!
Comment | File | Size | Author |
---|---|---|---|
#5 | date-repeat-presets-1527964-5.patch | 1 KB | pillarsdotnet |
Comments
Comment #1
tim.plunkettI set up a date field to use date repeat presets, and I go to the node edit page.
First,
Fatal error: Call to undefined function date_repeat_bundles() in date_repeat_presets/date_repeat_presets.module on line 40
. It seems that date_repeat_bundles has been renamed date_repeat_field_bundles. Easy enough.Then, once I fix that, I get to this:
And looking at
_date_repeat_presets_alter_entity_form()
, I have no real idea what was going on, or what's broken now.There might be more, but that's the start of it.
Comment #2
chaps2 CreditAttribution: chaps2 commented@Tim - OK thanks. From your knowledge of the Date module is it worth maintaining this any longer? It's very tightly coupled to the Date module (out of necessity) and would be so much better as a patch which was what I had originally intended.
Also, I'd like to change your warning to a more helpful message to say which version of Date is supported but I can no longer see an edit link. Am I missing something?
Comment #3
tim.plunkettThis is apparently affecting the 6.x version as well.
I'm also worried about the tight coupling with Date module, perhaps its time to rethink things.
Comment #4
dkre CreditAttribution: dkre commentedThis module seems to be stable with Date 7.x 2.3
Comment #5
pillarsdotnet CreditAttribution: pillarsdotnet commented#1 expressed as a patch. After making this change I did not experience the other errors mentioned.
Comment #6
hoff331 CreditAttribution: hoff331 commentedIs this patch working? If so, can we get a new, stable release of the module with the applied patch?
Comment #7
tim.plunkettSomeone needs to test it.
If someone tests it, and determines that it works, they can mark it RTBC and then I will commit it and tag a new release.
Comment #8
hoff331 CreditAttribution: hoff331 commented#5 seems to have tested the patch successfully
@pillarsdotnet - any problems?
Sorry, not a developer, just a themer (I don't have GIT and cannot test the patch myself)! This module rocks though and I would love to use it.
Comment #9
rockland CreditAttribution: rockland commentedJust wondering if anyone has a patch for the current version (7.x-1.2)? The patch doesn't work anymore.
Comment #10
hoff331 CreditAttribution: hoff331 commentedThis patch was for the 7.x-1.2 version, so it would work with Date 7.x-2.6. Date has not released an updated version, so this is the only patch available. I tried contacting @pillarsdotnet, but did not get a response. Looks like we need a new patch.
Comment #11
pillarsdotnet CreditAttribution: pillarsdotnet commentedTagging. Patch re-rolling is a novice issue.
Comment #12
Asome CreditAttribution: Asome commentedit don't works for me too, without and with patch #5
Standard repeat rule works
Selection of rules not works
Single rule not works
Notice : Undefined index: rrule_apply in _date_repeat_presets_rrule_validate() (ligne 277 of sites/all/modules/date_repeat_presets/date_repeat_presets.inc).
module Date 7.x-2.6+2-dev
Comment #13
thamasSame problem here as in #12. Module doesn't work with or without patch in #5.
Comment #14
thamasDear hoff331, you tell it wrong. The patch is not for the latest stable release (7.x-1.2) but for the latest development version (from Nov 2011, available via git). However it doesn't make the module work. :(
Comment #15
thamasWrong net connection tripled submittion of comment. Sorry for that! (Notice: I edited them)
Comment #16
thamasEntries in the log:
…and so on with different line numbers.
Comment #17
geek-merlinSo as for #12 and #13 it's needswork and surely not novice.
Comment #18
sahaj CreditAttribution: sahaj commentedSame problem here. Would be really happy to be able to use this module. Any chance to see the issue solve?
Comment #19
deanflory CreditAttribution: deanflory commentedStill an issue?
Comment #20
sahaj CreditAttribution: sahaj commentedYes, and would really be glad to find a way to fix it.
Comment #21
chrislabeard CreditAttribution: chrislabeard commentedSo whats the status on this?