"This module has fallen behind the latest releases of Date module, there is a good amount of work to be done until it is stable again."

The issue queue is the correct place for dealing with this. @Tim - please elaborate!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned

I set up a date field to use date repeat presets, and I go to the node edit page.

First, Fatal error: Call to undefined function date_repeat_bundles() in date_repeat_presets/date_repeat_presets.module on line 40. It seems that date_repeat_bundles has been renamed date_repeat_field_bundles. Easy enough.

Then, once I fix that, I get to this:

  • Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 39 of date_repeat_presets/date_repeat_presets.inc).
  • Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 52 of date_repeat_presets/date_repeat_presets.inc).
  • Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 52 of date_repeat_presets/date_repeat_presets.inc).
  • Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 52 of date_repeat_presets/date_repeat_presets.inc).
  • Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 62 of date_repeat_presets/date_repeat_presets.inc).

And looking at _date_repeat_presets_alter_entity_form(), I have no real idea what was going on, or what's broken now.

There might be more, but that's the start of it.

chaps2’s picture

@Tim - OK thanks. From your knowledge of the Date module is it worth maintaining this any longer? It's very tightly coupled to the Date module (out of necessity) and would be so much better as a patch which was what I had originally intended.

Also, I'd like to change your warning to a more helpful message to say which version of Date is supported but I can no longer see an edit link. Am I missing something?

tim.plunkett’s picture

This is apparently affecting the 6.x version as well.

I'm also worried about the tight coupling with Date module, perhaps its time to rethink things.

dkre’s picture

This module seems to be stable with Date 7.x 2.3

pillarsdotnet’s picture

Status: Active » Needs review
FileSize
1 KB

#1 expressed as a patch. After making this change I did not experience the other errors mentioned.

hoff331’s picture

Category: task » bug
Priority: Normal » Critical
Status: Needs review » Patch (to be ported)

Is this patch working? If so, can we get a new, stable release of the module with the applied patch?

tim.plunkett’s picture

Status: Patch (to be ported) » Needs review

Is this patch working?

Someone needs to test it.

If so, can we get a new, stable release of the module with the applied patch?

If someone tests it, and determines that it works, they can mark it RTBC and then I will commit it and tag a new release.

hoff331’s picture

#5 seems to have tested the patch successfully

@pillarsdotnet - any problems?

Sorry, not a developer, just a themer (I don't have GIT and cannot test the patch myself)! This module rocks though and I would love to use it.

rockland’s picture

Just wondering if anyone has a patch for the current version (7.x-1.2)? The patch doesn't work anymore.

hoff331’s picture

This patch was for the 7.x-1.2 version, so it would work with Date 7.x-2.6. Date has not released an updated version, so this is the only patch available. I tried contacting @pillarsdotnet, but did not get a response. Looks like we need a new patch.

pillarsdotnet’s picture

Issue tags: +Novice

Tagging. Patch re-rolling is a novice issue.

Asome’s picture

it don't works for me too, without and with patch #5

Standard repeat rule works
Selection of rules not works
Single rule not works

Notice : Undefined index: rrule_apply in _date_repeat_presets_rrule_validate() (ligne 277 of sites/all/modules/date_repeat_presets/date_repeat_presets.inc).

module Date 7.x-2.6+2-dev

thamas’s picture

Status: Needs review » Needs work

Same problem here as in #12. Module doesn't work with or without patch in #5.

thamas’s picture

Dear hoff331, you tell it wrong. The patch is not for the latest stable release (7.x-1.2) but for the latest development version (from Nov 2011, available via git). However it doesn't make the module work. :(

thamas’s picture

Wrong net connection tripled submittion of comment. Sorry for that! (Notice: I edited them)

thamas’s picture

Entries in the log:

Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 113 of […]/sites/all/modules/contrib/date_repeat_presets/date_repeat_presets.inc).

Notice: Undefined index: rrule in _date_repeat_presets_alter_entity_form() (line 62 of […]/sites/all/modules/contrib/date_repeat_presets/date_repeat_presets.inc).

…and so on with different line numbers.

geek-merlin’s picture

So as for #12 and #13 it's needswork and surely not novice.

sahaj’s picture

Same problem here. Would be really happy to be able to use this module. Any chance to see the issue solve?

deanflory’s picture

Issue summary: View changes

Still an issue?

sahaj’s picture

Yes, and would really be glad to find a way to fix it.

chrislabeard’s picture

So whats the status on this?