node creation time test fails due to timezone [#1528586]

Comment	File	Size	Author
#6	just_the_fix.patch	1.21 KB	Berdir

#5	does_this_fix_it.patch	1.61 KB	Berdir

#2	let_the_debugging_begin.patch	1.29 KB	Berdir

Comment #1

joachim CreditAttribution: joachim commented 13 April 2012 at 13:46

It's more likely something funny with timezones going on here:

'@date' => format_date($date->getTimestamp()))))

Log in or register to post comments

Comment #2

Berdir

German

Switzerland

CreditAttribution: Berdir commented 13 April 2012 at 17:30

File	Size
let_the_debugging_begin.patch	1.29 KB

Enable the assertion and added some debug calls.

Let's see what the testbot is actually doing there.

Log in or register to post comments

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 13 April 2012 at 17:41

Status:

Active

» Needs review

Log in or register to post comments

Comment #4

13 April 2012 at 17:43

Status:

Needs review

» Needs work

The last submitted patch, let_the_debugging_begin.patch, failed testing.

Log in or register to post comments

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir commented 13 April 2012 at 17:54

Status:

Needs work

» Needs review

File	Size
does_this_fix_it.patch	1.61 KB

Ah, I think this might actually be easier than I thought.

You're calling variable_set('date_default_timezone', 'Europe/Kiev')) in setUp(). This does *not* affect the code within the test, because that relies on the the date_default_timezone_get(), which returns whatever is set in PHP, not Drupal.

However, when we do a page request then we are going through the session handling, which sets the PHP timezone based on that variable.

So, doing that as well in setUp() should probably fix this. I'm not sure if we should do this by default, though but instead only in the test classes we want it and are doing timezone-specific assertions.

Log in or register to post comments

Comment #6

Berdir

German

Switzerland

CreditAttribution: Berdir commented 13 April 2012 at 18:01

File	Size
just_the_fix.patch	1.21 KB

Yep, that works.

Now without debug().

Log in or register to post comments

Comment #7

joachim CreditAttribution: joachim commented 13 April 2012 at 22:36

Status:

Needs review

» Fixed

> You're calling variable_set('date_default_timezone', 'Europe/Kiev')) in setUp(). This does *not* affect the code within the test, because that relies on the the date_default_timezone_get(), which returns whatever is set in PHP, not Drupal.

I was expecting the setting of PHP's default in session.inc to have happened by then, but I admit that was an assumption rather than based on any knowledge of what gets set up during a test run!

Thanks for the fix!

- #1528586 by Berdir: Fixed node creation test submitted time failing due to timezone.