I'm not really sure it should require curl at all, since drupal_http_request is available in core (and thus on any Drupal installation). But since I don't know the limitations of drupal_http_request and don't have the time to check what DrupalOAuth2Client is doing with curl, I'm providing a patch to warn new users that curl is a requirement for oauth_common.
I've created a similar bug report for the OAuth module as well, see #1529166: Module requires curl but it is not declared in hook_requirements, but it should be added to oauth2_common as well since oauth might switch to drupal_http_request anytime and oauth2_common might follow up later (or earlier, who knows).
Comment | File | Size | Author |
---|---|---|---|
#1 | 1529186-oauth-adding-curl-to-hook-requirements.patch | 1.36 KB | barraponto |
Comments
Comment #1
barraponto CreditAttribution: barraponto commentedComment #2
Frans CreditAttribution: Frans commentedPatch is fine, but shouldn't this be solved by a dependency on oauth_common?
The submodule oauth2_common cannot stand on its own and IMHO shouldn't even exist. It is born to support FB in oauthconnector, but it 'should' live in oauth_common.
Comment #3
barraponto CreditAttribution: barraponto commentedThis has just been commited in #1529166: Module requires curl but it is not declared in hook_requirements. I submitted a patch here as well since OAuth might move away from cURL some day, but oauth2_common might still need it. BTW, juampy changed the patch to make it clear that the requirement is related to OAuth, maybe we should do the same here.