Part of meta-issue #1518116: [meta] Make Core pass Coder Review

  • Yellow warning from Drupal 8 branch test code review (one normal reported, not enumerated)
  • No errors or warnings reported using Coder 8
    • Minor: Drupal Coding Standards, Drupal Commenting Standards, Drupal SQL Standards, Drupal Security Checks, Internationalization
  • No errors or warnings reported using Drupal Code Sniffer
    • phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme
Files: 
CommentFileSizeAuthor
#21 drupal-make_config_module_pass_coder_review-1533202-21.patch62.18 KBvisabhishek
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,345 pass(es), 9 fail(s), and 0 exception(s).
[ View ]
#19 drupal-make_config_module_pass_coder_review-1533202-19.patch62.08 KBvisabhishek
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal-make_config_module_pass_coder_review-1533202-19.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#8 config_standardized-1533202-5900836.patch6.02 KBFluxSauce
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch config_standardized-1533202-5900836.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 config_standardized-1533202.patch8.51 KBFluxSauce
PASSED: [[SimpleTest]]: [MySQL] 35,363 pass(es).
[ View ]

Comments

Assigned:Unassigned» FluxSauce

Status:Needs review» Active
StatusFileSize
new8.51 KB
PASSED: [[SimpleTest]]: [MySQL] 35,363 pass(es).
[ View ]

Completed.

Status:Active» Needs review

Per the instructions in the meta issue, @FluxSauce, everything you have in comment #2 should be moved to the issue summary, and you don't need to document what you fixed—only reported errors that you didn't fix. See an example at #1512434: Make Aggregator module pass Coder Review.

Sorry about that @TravisCarden, I'll reconcile shortly. Thanks for the feedback.

Status:Active» Needs review

Summarized.

Issue summary:View changes

Summarizing work done

Issue summary:View changes

Bum HTML

Status:Needs review» Needs work

A couple of things.

According, to http://drupal.org/node/811254 getInfo() should not be translated with t().
While it is still being debated #338403: Use {@inheritdoc} on all class methods (including tests) for now we are not adding docblocks to getInfo(), setUp(), and tearDown().

Refer to http://drupal.org/node/1354 for all documentation standards, and http://drupal.org/node/325974 for SimpleTest specific standards.

Status:Needs work» Needs review
StatusFileSize
new6.02 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch config_standardized-1533202-5900836.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

@NROTC_Webmaster thanks for the review, I've corrected the issues as described. I made the getInfo() translate error elsewhere as well; glad I know about it now.

Status:Needs review» Needs work
Issue tags:+Configuration system

Patch no longer applies.

Not updating until #1518116: [meta] Make Core pass Coder Review is no longer postponed.

Should we postpone this then?

Status:Needs work» Postponed

Yes.

When a patch for this issue is next re-rolled, we need to ensure that a blank line is added after the last method and closing brace of the class for test classes like LocaleConfigOverride.php.

Assigned:FluxSauce» Unassigned

Issue summary:View changes

Cleanup

Issue summary:View changes
Status:Postponed» Active

Assigned:Unassigned» visabhishek

Status:Active» Needs review
StatusFileSize
new62.08 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal-make_config_module_pass_coder_review-1533202-19.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I have Created a patch. Please review.

Status:Needs review» Needs work

The last submitted patch, 19: drupal-make_config_module_pass_coder_review-1533202-19.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new62.18 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,345 pass(es), 9 fail(s), and 0 exception(s).
[ View ]

Patch updated.

Status:Needs review» Needs work

The last submitted patch, 21: drupal-make_config_module_pass_coder_review-1533202-21.patch, failed testing.

Assigned:visabhishek» Unassigned

The last submitted patch, 8: config_standardized-1533202-5900836.patch, failed testing.