Now that 5.x-2.0-beta is out, the next critical step towards getting this in core is getting it working with the D6 API. My preference would be to create the DRUPAL-5--2 branch ASAP, and do this porting work directly in HEAD. Getting it working as a separate module using the D6 API seems like a great way to get this closer to a core patch, even though some things will change once this is directly in core. However, most of it will be identical once it's working in D6, so we can start there.
Attached patch handles everything except the E_ALL warnings. There are still a ton of those -- see http://drupal.org/node/153502 about that.
Comment | File | Size | Author |
---|---|---|---|
#10 | update_status_d6.patch_6.txt | 10.83 KB | dww |
#9 | update_status_d6.patch_5.txt | 9.33 KB | dww |
#8 | update_status_d6.patch_4.txt | 8.07 KB | dww |
#6 | update_status_d6.patch_3.txt | 8.03 KB | dww |
#3 | update_status_d6.patch_2.txt | 7.76 KB | dww |
Comments
Comment #1
dwwtee hee, forgot one of the most important parts:
define('UPDATE_STATUS_CORE_VERSION', '6.x');
;)
Comment #2
dwwno longer applies, i'll re-roll.
Comment #3
dwwComment #4
webchickSubscribe. I'm going to need to test this. :)
Comment #5
dwwneeds re-roll based on recent changes. however, it'll need another once http://drupal.org/node/153741 lands, so i'm gonna wait for that before i do anything else here.
Comment #6
dwwNow that 5.x-2.0-beta2 is out, seemed safe to re-roll this.
Whadaya say, merlin? When should we branch for DRUPAL-5--2 and let HEAD become the D6 playground?
Comment #7
dwwKeeping up with HEAD. This will break again once I commit http://drupal.org/node/124715, but I figured I should leave a fresh one here in case anyone wants to test in the mean time. ;)
Also, once this is committed, there's still the relatively large task of dealing gracefully with themes: http://drupal.org/node/124304. But, I'm keeping all such effort out of this issue and patch. Just wanted to remind people who are following this that this other thing needs to get done, too.
Comment #8
dwwsorry, the patch this time. ;)
Comment #9
dwwI committed http://drupal.org/node/124715 so here's a new version. Needs a little testing.
In addition to themes, we need to change this if http://drupal.org/node/152926 (hook_system_info_alter()) lands.
Comment #10
dwwNew version that keeps up with update_status HEAD and takes advantage of http://drupal.org/node/144132#passing to better deal with the validation of email addresses using $form_state.
And yay!!! hook_system_info_alter() landed, so we don't need hook_version_alter() anymore in the D6 version. ;) I'll fix cvs_deploy D6 to handle that in a second.
Comment #11
dwwCommitted this to the newly renamed version of this module in my sandbox:
http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/dww/update
See http://drupal.org/node/153968#comment-266276 (comment #22) for more info about the new name.
Comment #12
(not verified) CreditAttribution: commented