Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Please maintainers, rename this module properly following Drupal standards. I saw a few posts dealing with this and apparently it has not been dealt with: Either rename the enclosing folder to "clone" or rename the full module "node_clone". Not doing so breaks workflow with Drush and adds an unneccesary glitch to it.
Then have a margarita.
Great module btw.
Comments
Comment #1
tezalsec CreditAttribution: tezalsec commentedSubscribing..
I am building a custom module that retrieves info from all other contrib modules, and this node_clone module which I am happily using, seems to be the only one not respecting namespaces behaviour. It seems node_clone and clone are both used, and it messes up my dynamic functions building arrays collecting info from all installed contrib modules.
If it is at all possible, please consider respecting namespaces, maybe renaming the project to clone, or the files and functions to node_clone_etc...
thanks!
Comment #2
r2integrated CreditAttribution: r2integrated commented+1
Comment #3
pwolanin CreditAttribution: pwolanin commentedEverything in the module is "clone". I don't feel that relocating the project would be in the best interest of existing users.
Comment #4
Agileware CreditAttribution: Agileware commentedHi,
I ask that you re-consider bringing this module in-line with the Drupal module standards, having the module called "node_clone", yet the module itself called "clone" is confusing and problematic.
If you are using drush then you can get stuck in this infinite loop:
$ drush dl node_clone
Project node_clone (7.x-1.0-rc1) downloaded to [success]
/public_html/sites/all/modules/contrib/node_clone.
Project node_clone contains a module named clone.
$ drush -y en node_clone
node_clone was not found. [warning]
The following projects provide some or all of the extensions not found: [ok]
node_clone
Would you like to download them? (y/n): y
Install location /public_html/sites/all/modules/contrib/node_clone already exists. Do you want to overwrite it? (y/n): n
Skip installation of node_clone to /public_html/sites/all/modules/contrib/node_clone.[warning]
node_clone was not found.
...
(infinite loop starts)
So please consider renaming the module and all functions completely to "node_clone"
Thanks!
Comment #5
pwolanin CreditAttribution: pwolanin commentednot for any stable release - maybe for 8.x
Comment #6
pwolanin CreditAttribution: pwolanin commentedAlso, you appear not to be reading the drush output which clearly says:
"Project node_clone contains a module named clone"
Comment #7
rdworianyn CreditAttribution: rdworianyn commentedThe project should be moved to "clone". Every module needs to follow the proper naming conventions, this one included. Either that, or all of the code needs to be updated to use node_clone instead so that the project doesn't have to be moved.
Comment #8
pwolanin CreditAttribution: pwolanin commentedThere is no possibility that I am going to rename it all for 7 or 6.