In order to confine the responsibilities of the mailsystem module, the mailsystem_html_to_text method is extracted into a separate independent submodule.

Comments

Status:Active» Closed (won't fix)

Actually, it should be a core patch.

OK, would it be possible to remove the code from mailsystem completely?

As soon as it gets patched in core, yes.

If you have a problem with how mailsystem_html_to_text() is implemented, I would entertain a patch either to fix it or to let the user choose between the system version and the improved version included with mailsystem.

If you have a problem with how mailsystem_html_to_text() is implemented

I do not use mailsystem_html_to_text at all, my long term goal is to get rid of the hook_init implementation in mailsystem. The method mailsystem_html_to_text is referenced there at the moment and I'm just offering an alternative approach.

let the user choose between the system version and the improved version included with mailsystem.

That is exactly the purpose of this patch: Extract it into its own module plus wrap it into a EnhancedHTMLtoTextMailsystem class such that users may select it as the formatter class in the mailsystem admin ui. Currently it is not exposed at all to end users.

Status:Closed (won't fix)» Needs review

Okay; I'll take a look.

Version:7.x-2.x-dev» 7.x-3.0-alpha1
StatusFileSize
new59.35 KB

Updated patch for 7.x-3.x