Unable to save role badges.

Wow... I was debugging this thing and writing something as I went then totally Google searched with this tab and lost my text.

I have the same problem.

The "correct" code, from looking at the 6.x module, should be:

if ($rid > 2) {
          $query = db_select('users_roles', 'u')
          ->fields('u', array('uid'))
	  ->condition('u.rid', $rid)
          ->isNull('ubu.uid')
          ;
        }

I think, at least.

After that I get this error:

PDOException: SQLSTATE[21S01]: Insert value list does not match column list: 1136 Column count doesn't match value count at row 1: INSERT INTO {user_badges_user} (uid, bid, type) VALUES (:db_insert_placeholder_0_0, :db_insert_placeholder_0_1, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_1] => 1 [:db_insert_placeholder_2] => role [:db_insert_placeholder_0_0] => 1 [:db_insert_placeholder_0_1] => 2 ) in user_badges_save_roles() (line 1214 of .../user_badges/user_badges.module).

No idea on that one but now I'm almost late for something. Hopefully this will help someone... but I am new to all this.

Edit:

Just got back. I'm going to start from the old module function and rewrite the queries to work with D7. I hope that will do the trick. Just trying to understand this, as I need it to work.

Edit2:

Seems to work for me! I'll submit a patch after I figure out how to.

I don't really know how the patch file system works.

This is what I changed:

/**
 * Save information about roles for user_badges (in settings)
 *
 * @param $roles
 *   An array in the format rid => bid for each role/badge relationship.
 */
function user_badges_save_roles($roles) {
  if (is_array($roles)) {
    //We have to clear out all badges first
    $success = TRUE;
    db_query('DELETE FROM {user_badges_roles}');
    db_query("DELETE FROM {user_badges_user} WHERE type='role'");

    //Now we loop through the roles and their badges, and assign them to each user accordingly
    foreach ($roles as $rid => $bid) {
      if ($bid) {
        //First of all, insert all the role and badge relationship into user_badges_roles
        $success = $success && db_query('INSERT INTO {user_badges_roles} (rid, bid) VALUES (:rid, :bid)', array(':rid' => $rid, ':bid' => $bid));

        //For all of these queries, we LEFT JOIN user_badges_user to check whether there are existing entries for that badge for
        //that user of the "role" type. Otherwise, we get database errors when multiple roles assign the same badge

        // The blocked user "role" (represented as rid 0) has no entry in the users_role table, so it needs its own special query
        if ($rid == 0) {
          $success = $success && db_query("
            INSERT INTO {user_badges_user} (uid, bid, type)
            SELECT u.uid, :bid, 'role'
            FROM {users} u
            LEFT JOIN {user_badges_user} ubu
            ON ubu.uid=u.uid AND ubu.bid=:bid AND ubu.type='role'
            WHERE status = 0 AND ubu.uid IS NULL
          ", array(':bid' => $bid));
        }
        // The authenticated user role (represented as rid 2) has no entry in the users_role table, so it needs its own special query
        elseif ($rid == 2) {
          $success = $success && db_query("
            INSERT INTO {user_badges_user} (uid, bid, type)
            SELECT u.uid, :bid, 'role'
            FROM {users} u
            LEFT JOIN {user_badges_user} ubu
            ON ubu.uid=u.uid AND ubu.bid=:bid AND ubu.type='role'
            WHERE u.uid > 0 AND ubu.uid IS NULL
          ", array(':bid' => $bid));
        }
        //For all the normal roles, we want to run this query
        else {
          $success = $success && db_query("
            INSERT INTO {user_badges_user} (uid, bid, type)
            SELECT ur.uid, :bid, 'role'
            FROM {users_roles} ur
            LEFT JOIN {user_badges_user} ubu
            ON ubu.uid=ur.uid AND ubu.bid=:bid AND ubu.type='role'
            WHERE ur.rid=:rid AND ubu.uid IS NULL
          ", array(':bid' => $bid, ':rid' => $rid));
        }
      }
    }
    if ($success) {
      drupal_set_message(t('Roles saved.'));
    }
    else {
      drupal_set_message(t('There was a problem saving roles to the database'));
    }
  }
}

I just took the function from 6.x, replaced the 7.x function with it, then updated all the queries to 7.x syntax. It seems to work for me but I must stress that I am new to this.

My badge image file is also being deleted from the folder but the badge remains. Other folders, such as user title images and user pictures, are not cleared so this is unique to badges.

I'm checking in on user_badges_user_presave now.

Edit:

I don't get that notice message when editing a user profile and blocking someone, but the function is called and I had it print the $account variable - which had badges_all in it. Where do these notices occur for you, page wise?

Edit2:

Found the warning and notice in my log from when a user registered.

I created a separate issue for this here. I don't have any intention of fixing it at the moment unless it is causing problems.

Hi,
unable to apply this patch, is it still in use?

patch from #1 worked for me, i can now save the role based tags with no errors.

Patch committed (I've rewritten comments according to Drupal Coding standards)