simplenews.module currently starts like this:

/**
 * @defgroup simplenews
 * Enable nodes to be used as newsletter, manage subscriptions and sent
 * email newsletter to subscribers.
 */
/**
 * @file
 * Simplenews node handling, sent email, newsletter block and general hooks
 *
 * @ingroup simplenews
 * @todo Where possible build re-usable functions wrapped around database calls.
 * @todo Consider context support for t(): 
 * @todo Coding standards: type hinting
 * @todo Implement hook_requirements()?; 
 * @todo Separate token function into simplenews.tokens.inc
 * @todo Consider using hook_hook_info() to move hooks out of .module. 
 */

The initial @defgroup is not necessary. As for the @todo's:
- Check if there are remaining direct db_* uses in non API functions like forms, page callbacks and hook implementations. Check if we can move them into API functions.
- Haven't seen a need for t() context, remove that
- Coding standards have been cleaned up, type hinting doesn't make much sense until we have entity classes, remove.
- I don't know what we could possibly check in hook_requirements(), remove.
- Moving the token hooks makese sense.
- hook_hook_info() doesn't help us, we can only do it for our own hooks. Remove.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Oh, looks like the blocks with links get messed up...

corvus_ch’s picture

FileSize
12.92 KB
Berdir’s picture

Status: Active » Needs review
Berdir’s picture

Status: Needs review » Needs work
+++ b/simplenews.moduleundefined
@@ -1,7 +1,6 @@
 /**
- * @defgroup simplenews
  * Enable nodes to be used as newsletter, manage subscriptions and sent
  * email newsletter to subscribers.

You can delete the whole block here.

+++ b/simplenews.moduleundefined
@@ -10,12 +9,6 @@
  * @ingroup simplenews

And this as well. We are removing the defgroup from above, and adding a @ingroup to a @file docblock makes no sense anyway.

corvus_ch’s picture

Status: Needs work » Active
FileSize
12.92 KB
Berdir’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, simplenews-1546678-5.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review

#5: simplenews-1546678-5.patch queued for re-testing.

Berdir’s picture

Status: Needs review » Fixed

Commited and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.