Signature links don't get rel="nofollow" added in all cases

The all have rel=nofollow as far as I can tell. Which link is getting past the system in your opinion?

Michelle's signature link in sub doesn't have nofollow, but user asb's standard links do.

I also use sub in my signature, but I seem to get nofollowed (i.e. http://drupal.org/node/975052#comment-3723536)

definitely weirdly inconsistent-- my sig also uses sub, and is also correctly no-followed. Can't seem to find any other case though... still looking...

a

I'm closing this issue due to inactivity. If it is still a problem, please open this issue again and leave a comment. Thanks.

I think this issue gets more attention in this queue.

Comments like https://www.drupal.org/drupalgive#comment-5812556 aren't actually using the signature for

Goutam Dey
[URL] - Social way of learning drupal

It is part of the comment body.

We can either consider nofollow-ing all comment content, or think about policies for enforcing using the comment body & signature "properly".

It's actually related to whether or not someone enters a link with the <a> tag or by typing the url and letting the url to link filter do it.

tag link: Drupal.org (correctly given 'nofollow')

auto link: http://drupal.org (missing 'nofollow').

I believe it's caused by the order of the filters. The 'Convert URLs into links' filter has to come before the 'Limit allowed HTML tags' filter and the 'Add rel="nofollow" to all links' option must be checked.

WorldFallz, here is a fresh dev site: http://searchdocs-drupal.redesign.devdrupal.org/. Can you take a look there and confirm that it's indeed filter order?

Sure! But I just tried to get there and after drupal/drupal I'm getting a white screen....

Cafuego was working on something there and probably broke it :)
You can test on mine for now http://tvn-drupal.redesign.devdrupal.org/

Thanks!

that one works! can you email me an admin username/pass ? I need at least enough access to get to admin/config/content/formats... thanks.

Yep... that was it. I fixed by moving the 'Convert URLs into links' filter to be the first filter in the 'filtered html' text format.

You can see it here: https://tvn-drupal.redesign.devdrupal.org/node/2372259

Actually.. that's not a good solution quite yet.

I commented on https://tvn-drupal.redesign.devdrupal.org/node/2372259 with

http://example.com

And [/codefilter_code] gets added.

OKey doke... moved code filter to before url converter.

Any chance we could push this forward. With all the changes to user participation, it would be great to get this one fixed once and for all. I still see quite a few links missing the 'nofollow'.

I think this needs a bit more testing, which I'll require for #2396165: Code filter configuration removes blank lines. Re-ordering filters is just too likely to have side-effects without good QA.

And the specific order change needed added to the issue summary here.

Ah I hadn't seen that one. So we need to wait for that to be fixed first, and then do some more testing for this one?

Added the other issue as related. And I'll look for that one to be fixed, so I can pick and do some more testing when it's done.

Ideally both should be fixed at once, since they are both re-ordering filters. However, if either has good testing and is ready significantly earlier, that one doesn't need to be held back.

#2396165: Code filter configuration removes blank lines is now deployed, which includes adding nofollow to URLs converted to links. This should cover signatures too, but I do want to double check new comments, since the old filtering is cached.

The cc all from another deployment fixed up the existing signatures. They must have been hitting the check_markup() cache.

Yep-- from what I can see, all links (content and sig) are properly no-followed again. Awesome!