These warnings popped at the same time. I was adding a project.

Warning: Missing argument 4 for storm_dependent_select_process(), called in /var/www/schoolyard/playground3/webroot/includes/form.inc on line 1766 and defined in storm_dependent_select_process() (line 939 of /var/www/schoolyard/playground3/webroot/sites/sandbox7.highlights.com/modules/storm/storm.module).
Notice: Undefined index: body in theme_stormproject_view() (line 125 of /var/www/schoolyard/playground3/webroot/sites/sandbox7.highlights.com/modules/storm/stormproject/stormproject.theme.inc).
Notice: Undefined index: body in theme_stormproject_view() (line 125 of /var/www/schoolyard/playground3/webroot/sites/sandbox7.highlights.com/modules/storm/stormproject/stormproject.theme.inc).
Files: 
CommentFileSizeAuthor
#3 stormproject-1549820-addbodyfield-comment3.patch2.84 KBesoteric1
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Comments

I just installed most recent dev release (Storm 7.x-1.x-dev tar.gz (224.04 KB) 2012-Oct-18) which went well. Went to create a project and noticed this error when create project page was displayed. Looks like this issue is still an issue...

Notice: Undefined property: stdClass::$has_body in stormproject_form() (line 634 of mysite/sites/all/modules/storm/stormproject/stormproject.module).

Warning: Missing argument 4 for storm_dependent_select_process(), called in mysite/includes/form.inc on line 1797 and defined in storm_dependent_select_process() (line 939 of /mysite/sites/all/modules/storm/storm.module).

Assigned:Unassigned» esoteric1

going to apply the same method used to patch this in stormorganization. It may also be an issue for stormperson as well. I'll create an issue.

Status:Active» Needs review
StatusFileSize
new2.84 KB
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

patch for stormproject

Looks like what we need from my first read-through.

Just a couple of trailing whitespace bits that could be sorted out.

Would you mind explaining the whitespace issue so I can avoid it next time?

Firstly I need to emphasise that this is really minor. Whitespace errors are just when there are spaces at the end of a line, or on empty lines. Drupal coding standards say we should avoid this, as it makes the code a bit cleaner.

I'd strongly recommend dreditor (https://drupal.org/project/dreditor), which is a browser plugin that helps make issue queues and issues on drupal.org a bit more user friendly. First of all, it will hide the fixed issues in a queue (useful when there is a lot of activity going on), secondly, a review button will appear by each patch. dreditor will highlight the code and show if there are whitespace issues.

BUT - I want to reiterate that it isn't a major point, so let's focus on the functionality above anything else!

Status:Needs review» Fixed

Committed, thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.