Issue to move the file/add from media to file.

Files: 
CommentFileSizeAuthor
#6 1552920_6_remove_file_add_from_media_module.patch9.42 KBmtift
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]
#2 1552920_1_remove_file_add_from_media_module.patch8.81 KBLetharion
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
remove_file_add_from_media_module.patch7.9 KBLetharion
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

Status:Active» Needs review

Second attempt.

StatusFileSize
new8.81 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

I hear actually uploading patches is also a good idea.

Complementary file entity issue: #1552988: Move file/add from media to file.

I seems to me like the two default values max_filesize and file_extensions could now be removed from the media module, but I'm not sure of this so I'm leaving them for now.

Issue tags:+sprint, +Media Initiative

Adding sprint tags.

StatusFileSize
new9.42 KB
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]

Patch #1 from this issue (1552920) -- in conjunction with patch #1 from #1552988: Move file/add from media to file -- worked fine to fix uploading from file/add.

I changed the instances of "drupal_get_form('media_add_" to "drupal_get_form('file_entity_" in includes/MediaBrowserUpload.inc so that the "Media file selector" widget is aware of the new namespace and will work properly.

Status:Needs review» Reviewed & tested by the community

#6 works for me (in conjunction w/ #1 from #1552988: Move file/add from media to file

Status:Reviewed & tested by the community» Fixed

Awesome! Committed to 7.x-2.x with http://drupalcode.org/project/media.git/commit/453fad5. Nice work all!

Automatically closed -- issue fixed for 2 weeks with no activity.