the masquerade settings field that gets added to the user profile form does not have any weight assigned to it.

as soon as a user adds additional fields; since the masquerade field does not show on the manage fields form, it can't be moved relative to the new fields and ends up showing up in the middle of these new fields:

http://screencast.com/t/janRHvjvqj7

attached patch simply assigns that field a weight of 10 to move it down with the other admin fields

Files: 
CommentFileSizeAuthor
#7 1561352-masquerade-field-7.patch922 bytesandypost
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in sites/default/modules/masquerade/masquerade.module.
[ View ]
#2 field-extra-1561352-2.patch855 bytesmokaspar
FAILED: [[SimpleTest]]: [MySQL] 16 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
masquerade-add_weight.patch507 bytesliquidcms
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch masquerade-add_weight.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Needs review» Needs work

To properly implement this functionality we need hook_field_extra_fields()

Title:masquerade field on user edit form should have weightAdd field ui support for user form and user display
Category:bug» feature
Status:Needs work» Needs review
StatusFileSize
new855 bytes
FAILED: [[SimpleTest]]: [MySQL] 16 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Here's a patch using hook_field_extra_fields().

Great, +1 to be commited. let's get more reviews

Status:Needs review» Reviewed & tested by the community

This patch is working nicely for me, fixing issues with not seeing the link when using Display Suite.

I think, after all this time, it's probably safe to commit!

My only comment, I usually consider it a good practice to instantiate variables:

<?php
$return
= array();
$return['user']['user']  = array(
  ...
);
?>

Thanks!

Status:Reviewed & tested by the community» Needs work

The last submitted patch, field-extra-1561352-2.patch, failed testing.

Version:7.x-1.x-dev» 8.x-2.x-dev
Status:Needs work» Patch (to be ported)

commited 8ee534e

Suppose this could be backported to 8x. probably to "advanced module"

Category:feature» task
Status:Patch (to be ported)» Needs review
StatusFileSize
new922 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in sites/default/modules/masquerade/masquerade.module.
[ View ]

pushed ea7dae9
still waits for advanced module

Status:Needs review» Needs work

The last submitted patch, 1561352-masquerade-field-7.patch, failed testing.

Status:Needs work» Fixed

pushed to 8.x-2.x

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.