Empty response from media browser plugin cause media browser to crash [#1565448]

Limiting media browser plugins visibility with user permissions cause the whole media browser to crash.
The error message is Fatal error: Unsupported operand media.browser.inc on line 52.
This happens because media browser is unable to handle empty responses from plugins that the user isn't allowed to use.

Patch to fix this bug is provided in this post.

Comment	File	Size	Author
#2	1565448-empty-browser-tab-output.patch	732 bytes	Dave Reid
#2
	media-browser-empty-plugins.patch	533 bytes	attekilpela

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

attekilpela CreditAttribution: attekilpela commented 7 May 2012 at 12:19

Status:

Patch (to be ported)

» Needs review

Comment #2

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 7 May 2012 at 16:35

Version:

7.x-1.0

» 7.x-1.x-dev

File	Size
1565448-empty-browser-tab-output.patch	732 bytes

I've confirmed the issue in theory (the proper way to limit permissions is to perform the user_access() checks in hook_media_browser_plugin_info() and not in the actual browser plugin) but here's an alternative patch that backports some of the defensive code to prevent an error in this case.