Thanks for a module. It is great.

However there is a bug. It causes to incredible slow down of Internet Explorer when editing nodes. It also affects other browsers too, but for IE9 this issue like a pain in the ass.

I have enabled Internet Explorer profile, which shows that some methods are run thousands of times:

clean, 96 seconds, 18 000 times
removeChild - 12 seconds, 9000 times
innerHTML, - 2 seconds, 18 000 times
appendChild - 2 seconds, 27 000 times
getElement byTagName - 0,5 sec, 27 000 times

I have many other modules enabled, but when I disable Meta Tag API, everything works fast. I have not tested to the recent dev version but going to check it now.

Comments

dealancer’s picture

dealancer CreditAttribution: dealancer commented
Title: JavaScript Performance Issue Internet (in Explorer) » JavaScript Performance Issue (crashes Internet Explorer)

Confirm, issue still exists in the recent dev version.

dealancer’s picture

dealancer CreditAttribution: dealancer commented
Project: Metatag » Token
Priority: Critical » Major

I have found that the issue is related to token module when building token replacement tree. It also happens with other module (e.g menu_token) which are using token.

So it is definitively an issue of Token module.

dealancer’s picture

dealancer CreditAttribution: dealancer commented
Issue tags: +JavaScript, +Page loading performance

After update to recent Token release, I have small performance increase, but still not good enough. Here is my results:

Method			Counter	Time (ms)	Time %
clean			9 674	20 794,19	71,49
removeChild		4 802	2 455,14	8,44
innerHTML		9 641	1 150,07	3,95
appendChild		14 522	848,05		2,92
getElementsByTagName	14 495	265,02		0,91
className		91 544	172,01		0,59
merge			24 404	162,01		0,56
trigger			354	160,01		0,55
add			5 706	155,01		0,53
createDocumentFragment	9 674	150,01		0,52

Time is Exclusive Time.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Closed (duplicate)

Yes the library does not perform well at all when overloaded with sheer amounts of tokens to render. We have active issues tagged with 'Performance' so I'm essentially marking this as a duplicate of those. Also updating to Token 7.x-1.0 will help as we reduced the default level of tokens deep that are rendered.

dealancer’s picture

dealancer CreditAttribution: dealancer commented

Thanks for feedback, I will try to help with these issues.

btw, I have found your module, which can also help: http://drupal.org/project/token_tweaks.