Domain paths should be visible only for selected (publish to) domains

The patch failed to apply against the latest dev branch.

Shouldn't we be using #attached here?

Base functionality looks fine. Need to test for a user with limited permissions.

Updated CrashTest's approach to work against the latest dev and to use #attached, and reworked the js a little for simplicity.

I've tested it on a user with limited permissions, but only with patches already applied from #1337500: Restrict user to only set path on assigned domains and #1425292: domain_path_node_insert() should update existing records rather than deleting/recreating them.

Patch re-roll. Applies cleanly to 7.x-1.x.

Tested limited access content creation.

Added: an over encapsulating hide on first run, to account for domains not listed in the "Publish to:" checkboxes.
(Don't think this will be needed once #1337500: Restrict user to only set path on assigned domains
&& #1425292: domain_path_node_insert() should update existing records rather than deleting/recreating them are applied.)

All seems to work.

Is any of this testable? I suspect not.

This approach does not work as expected when the user has the limited permissions "Publish content only from assigned domain " or "Publish content only from the default domain". In both cases, the domain form element is suppressed, so the JS never fires.

We should address that. I suspect by setting a preselected JS variable in this case. e.g. in this code:

  if // ... logic for user_access() {
    drupal_add_js('setting', SOME VALUE);
  }
  $form['domain_path'] = array(
    '#tree' => TRUE,
    '#title' => t('Domain-specific paths'),
    '#type' => 'fieldset',
    '#group' => 'additional_settings',
    '#access' => user_access('edit domain paths'),
    '#attached' => array(
      'js' => array(drupal_get_path('module', 'domain_path') . '/domain_path.js'),
    ),
  );

Now when the user does not have access to the domain field then a domain id js variable is created and the js will display that path field when set. Otherwise, it will look at the domain field.

Also cleaned up the js implementation and remove "$default_domain = domain_default();" which wasn't being used anywhere.

Minor grammatical corrections.

Ignore this patch its for #1425292: domain_path_node_insert() should update existing records rather than deleting/recreating them use #9 instead.

Seems to work, except an editor with limited domain permissions can still wipe all domain-specific paths for a node.

Do we need a separate permission for that?

Commited http://drupal.org/commitlog/commit/17364/35a7f0af5d06ab606ae8f8788f86af1...

Thanks all!

Also I have created a new ticket for the suggestion from #11 #1675896: Delete domain-specific aliases should not be visible by restricted permissions so lets continue discussion there.

If in 'admin/structure/domain/settings' we have selected the option 'Select list' this patch doesn't work (the edit form does not show any textbox for aliases).
Only works for 'Checkboxes' option.

@jca - there is a patch for that here: https://www.drupal.org/node/2173291
It checks whether you are using select list or checkboxes.