Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There are a few cases of mis-used whitespace, poor code style, improper spelling and incorrectly wrapped comments. This patch corrects these issue and most of the issues found by coder tough love module.
Comment | File | Size | Author |
---|---|---|---|
#2 | 1568322-coder-review.patch | 23.71 KB | Bevan |
coder-review.patch | 27.87 KB | Bevan | |
Comments
Comment #1
Dave ReidThis style of links in t() is actually incorrect. See http://drupal.org/node/322774 for explanation.
Same here. Looks like this would sanitize the link HTML as well.
Same here.
Same here.
According to coding standards (http://drupal.org/node/1354#functions) there should be an extra new line between @params and @return.
Same here.
Coding standards say we should use 'bool' and not 'Boolean'
Same
Comment #2
Bevan CreditAttribution: Bevan commentedComment #3
hass CreditAttribution: hass commented#2: 1568322-coder-review.patch queued for re-testing.
Comment #4
hass CreditAttribution: hass commentedNOTE: Coder tough love does not implement the correct Drupal rules. Use coder module, please.