Notice: Undefined index: payment_details

Thanks for the report. Could you give me some details on your configuration in the Drupal Commerce payment configuration page for this method? E.g. are you using "Select payment method localy" or not?

Do you have the Billing profile disabled on the checkout process? I currently have a hard dependency on that field and the addressfield in it. I can likely in the future make it function soundly with the addressfield (commerce_customer_address) removed but I'm not sure about the billing profile field at this time because I don't know what dependency Drupal Commerce might have on it itself. But hopefully removing that dependency will be safe as well. I won't be trying that for at least a couple of weeks though so patches welcome all ;)

That all sounds perfectly fine. I just tested with the address field set to use the two separate name fields (using a registered and anonymous user) and did not receive that notice. What version of Drupal Commerce do you have installed?

I'm guessing that for some reason on your setup commerce_payment_order_transaction_add_form_validate() does not have $form_state['values']['payment_details'] set.

Blue_Jumpers_Filip, could you do me a favour? In commerce/modules/payment/includes/commerce_payment.forms.inc in function commerce_payment_order_transaction_add_form_validate() change:

    if ($callback = commerce_payment_method_callback($payment_method, 'submit_form_validate')) {
      $callback($payment_method, $form['payment_terminal']['payment_details'], $form_state['values']['payment_details'], $order, array('payment_details'));
    }

To:

    if ($callback = commerce_payment_method_callback($payment_method, 'submit_form_validate')) {
      debug($form_state['values'], "commerce_payment_order_transaction_add_form_validate: $callback values");
      $callback($payment_method, $form['payment_terminal']['payment_details'], $form_state['values']['payment_details'], $order, array('payment_details'));
    }

Then when you are on the payment redirect page could you attach the output of the debug section please? You may want to edit it first to remove sensitive information like the WorldPay password.

Thanks

I just noticed you did not mention whether you have: "Select payment method localy" checked. I've just tried with it disabled and got the following:

Notice: Undefined index: payment_details in commerce_payment_pane_checkout_form_validate() (line 150 of /home/magicmyth/webapps/drup/sites/all/modules/contrib/commerce/modules/payment/includes/commerce_payment.checkout_pane.inc).
An invalid WorldPay payment method choice was recived. Please try choosing a payment method again.

Weirdly the issue of the undefined index is in a different place but that may be because I already had been through but cancelled the checkout with that anonymous session.

Anyway seems I broke the functionality at some point for when the payment method is chosen on WorldPay. I'll take a quick look at that.

I'm attaching a quick patch that should make the process work for you when payment method selection is not local. Pull the latest git commits and then this patch should apply cleanly. Note that I am getting the following error messages with this patch:

Notice: Undefined index: payment_details in commerce_payment_pane_checkout_form_validate() (line 150 of sites/all/modules/contrib/commerce/modules/payment/includes/commerce_payment.checkout_pane.inc).
Notice: Undefined index: payment_details in commerce_payment_pane_checkout_form_submit() (line 190 of sites/all/modules/contrib/commerce/modules/payment/includes/commerce_payment.checkout_pane.inc).

Need to figure out why payment_details is not set when 'pm_select_localy' is not set. A quick scan through the code does not reveal anything else that would be influenced by that setting. I can't look at that till later now.

Thanks for helping Blue_Jumpers_Filip.

Adam

Since we seem to have two separate but related issues here I have created a new issue (#1598338) for the failure of non-local payment method selection.

This is probably fixed now in the latest dev version of commerce, see #1705862: Notice: Undefined index: payment_details in commerce_payment_pane_checkout_form_submit()

Agreed w/ hadsie, should've been fixed there or in #1250900: Undefinex index payment_details when submitting payment terminal form.