Hi all.
I have fusion accelerator 7.x-2.0-beta1 module installed and Fusion Core 7.x-2.0-beta2 installed too.
When, using acquia marina I enable a block skin, setting the block title to 'green rounded title background with white text', or when I apply a title icon, the system apply a skin to the comment form too. If I disable the block skin, the comment form skin disappear too.
There's no way to disable the comment skin leaving the block skin activated; if i go in the applied skin list, i can't find the skin applied to the comment form.

CommentFileSizeAuthor
#16 1570358-acquiamarina-comment-form-not-styled.patch2.42 KBsheena_d
#8 BlockSkin.png141.31 KBedubacco
#8 noBlockSkin.png135.11 KBedubacco
#7 1570358-comment-form-title.patch545 bytessheena_d
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

esmerel’s picture

esmerel CreditAttribution: esmerel commented
Status: Active » Postponed (maintainer needs more info)

off the top of my head I can't think of a block with a comment form - is there some kind of specific form/block you're using here?

edubacco’s picture

edubacco CreditAttribution: edubacco commented

I'm sorry, I don't speak English very well and the problem is not clear.
I applied a skin to a block. When I view a full content, I see the section of the comment form with an applied skin, but i haven't applied it, and this skin don't figure out in the list of applied skin. The only way i encountered to remove this skin is disabling the block's skin.
I have more than one block and it's sufficient to apply a skin to one of them to make appear a (different) skin to the comment form.
Is it more clear now?
Thanks

edubacco’s picture

edubacco CreditAttribution: edubacco commented
Status: Postponed (maintainer needs more info) » Active
sheena_d’s picture

sheena_d CreditAttribution: sheena_d commented
Status: Active » Postponed (maintainer needs more info)

Can you post a link to the site where the issue is occurring so that we can investigate the problem?

edubacco’s picture

edubacco CreditAttribution: edubacco commented

http://floema.net/articoli/fattori-influenza-metaboliti-secondari-stevia...

edubacco’s picture

edubacco CreditAttribution: edubacco commented

now the comment form is visible.

sheena_d’s picture

sheena_d CreditAttribution: sheena_d commented
Title: skin applied uncorrectly » Comment form title styling incomplete
Status: Postponed (maintainer needs more info) » Fixed
FileSize
1570358-comment-form-title.patch545 bytes

This is not a skin applied, it is part of the intended styling of the Comments title - it seems that part of the styling for that element has been left out, which is causing the chat bubble icon to overlap the comment form title. You can see the full intended styling for that element on our demo site.

The attached patch corrects the styling for this element. I have committed this change and it should be available in the next nightly dev release.

edubacco’s picture

edubacco CreditAttribution: edubacco commented
Title: Comment form title styling incomplete » Comment form skin applied whit another skin
Status: Fixed » Active
FileSize
noBlockSkin.png135.11 KB
BlockSkin.png141.31 KB

Hmm ok the patches gives a new style to the title, and now the bubbles don't overlap title.
But this is not the problem.
The problem is that if i apply a skin to a block in the page, a skin is applied to the comment form too.
See the images i posted: in first image i have enabled a block skin (top-right of image, 'tag' block , and a skin has applied to the comment form. In the second image i have removed the block skin (the only skin i activated on page) and the comment form came back to its original style.
If i go on the comment form there is no link permitting me to create/delete/changin skin, same if i go to the applied skin page.
I want to apply skin to block without changing the style of the comment form.

sheena_d’s picture

sheena_d CreditAttribution: sheena_d commented

I can't think of any way that applying a skin to a block in the sidebar would affect the styling of the comment form. Is the only difference between those two screenshots that you added/removed a skin on the "tag" sidebar block? Did you not make any other changes, particularly to the skin on the "main content" block?

Is this happening across multiple browsers, or only in one specific browser?

Title: Comment form skin applied whit another skin » Comment about 307 status code is incorrect.
Project: Acquia Marina » Drupal core
Version: 7.x-2.0-beta1 » 7.x-dev
Component: Code » configuration system
Status: Active » Needs work
Issue tags: +Needs backport to D6, +Needs backport to D7

The last submitted patch, 1570358-comment-form-title.patch, failed testing.

mathankumarc’s picture

mathankumarc CreditAttribution: mathankumarc commented

Created a new issue in Drupal.org Testbots issue queue regarding malfunction of testbot #1577350: Bot moving other module's issues to Drupal core issue queue

edubacco’s picture

edubacco CreditAttribution: edubacco commented

What happend to my issue? the problem is with drupal core? there's something i don't understand

edubacco’s picture

edubacco CreditAttribution: edubacco commented

But this is what happens.
Yes, the only differences between the two screenshots was that i have added/removed the skin from the block 'tag'. There are no differencies between browsers.
I noted that if i add a skin that isn't in the 'acquia marina' group, all works properly, only the skin of the 'acquia marina' group makes the comment form change.
I've noted that there is no change in html between the two configuration, the
<div class="marina-gradient-rounded-corners">[...]</div> and the
<div class="block-icon pngfix comment-icon-chatbubbles"></div>
are present, but seems like that if you don't select a skin from acquia marina you don't load the css file to style these classes.

sheena_d’s picture

sheena_d CreditAttribution: sheena_d commented
Title: Comment about 307 status code is incorrect. » Comment form skin applied whit another skin
Project: Drupal core » Acquia Marina
Version: 7.x-dev » 7.x-2.0-beta1
Component: configuration system » Code
Status: Needs work » Active

A spam bot moved the issue, it is not a bug in Drupal core.

sheena_d’s picture

sheena_d CreditAttribution: sheena_d commented
Title: Comment form skin applied whit another skin » Comment form not styled completely
Status: Active » Fixed
FileSize
1570358-acquiamarina-comment-form-not-styled.patch2.42 KB

Some of the comment form's styles were accidentally included in the Marina skins CSS file rather than Marina's general CSS file. The attached patch applies to 7.x-2.0-beta1 and corrects all of the styling issues for the comment form. I have committed these changes and they should be available in the next nightly dev build.

mathankumarc’s picture

mathankumarc CreditAttribution: mathankumarc commented
Issue tags: -Needs backport to D6, -Needs backport to D7

@sheena_d
you forgot the issue tags. Clearing the tags.

edubacco’s picture

edubacco CreditAttribution: edubacco commented

So there is no way to edit comment form style with skins?!

sheena_d’s picture

sheena_d CreditAttribution: sheena_d commented

No, it is not intended to be edited with Skins. You can edit the styling by writing custom CSS.

edubacco’s picture

edubacco CreditAttribution: edubacco commented

Ok. But i think it's strange that the only icon present without skin is the icon associated to the comment form, no? All other icons must be settetd by skin.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

adding some details and removing (i hope) some grammar error. (sorry for my bad english)