Make the 'Reply-to address on e-mail notifications' setting (project_issue_reply_to) per-node-type [#1571404]

Subtask of #1569988: [Meta] Project issue settings D7 cleanup

If we're going to keep doing custom email notification code in project_issue, we're going to want the settings that control it to be per-node-type, not global site wide.

However, this issue is blocked on the outcome of #1560010: [META] Port issue following functionality to D7 since we might not need any settings for this functionality at all (e.g. it might all be implemented with customizable rules or something). [2012-06-26] This issue is no longer blocked.

Comment	File	Size	Author
#3	make-the-reply-to-email-setting-per-node-type-1571404-3.patch	3.74 KB	iamcarrico

Comments

Comment #1

iamcarrico commented 26 June 2012 at 16:43

Assigned:	Unassigned	» iamcarrico
Status:	Postponed	» Active

Was moving the setting, noticed that we have this functionality to include the mailhandler module. Do we want to still keep this or just remove it all together?

  if (module_exists('mailhandler')) {
    // TODO: move this stuff to mailhandler.module ?
    $items = array(t('<none>'));
    $result = db_query('SELECT mail FROM {mailhandler} ORDER BY mail');
    while ($mail = db_result($result, $i++)) {
      $items[$mail] = $mail;
    }

    // Switch reply-to to a select box instead.
    $form['project_issue_reply_to']['#type'] = 'select';
    $form['project_issue_reply_to']['#options'] = $items;
  }

Comment #2

dww

we/he/they

commented 27 June 2012 at 08:14

I'd love mailhandler support in project_issue, but that code hasn't been touched in over 6 years. No kidding. ;) I say we rip it all out for now, and if/when someone's motivated to get it working, we can re-add modern working code at that point.

Thanks,
-Derek

Comment #3

iamcarrico commented 27 June 2012 at 19:33

Status:

Active

» Needs review

Status	File	Size
new	make-the-reply-to-email-setting-per-node-type-1571404-3.patch	3.74 KB

Hokay. here is a patch.

Small note: it appears that the mail.inc file will have to have some work on it, but the relevant parts are changed here...

Comment #4

senpai commented 27 June 2012 at 20:56

Issue tags:

+sprint 5

Comment #5

dww

we/he/they

commented 10 July 2012 at 08:48

Status:

Needs review

» Fixed

The patch no longer applied given other recent commits. Since I had to re-roll, anyway, I ripped all the mailhandler code out over at #325570-2: create and control Issues with email.

Also, the stuff about %project and the "Short project name" was broken. However, all of mail.inc needs serious love from #1560012: Port per-user issue notification email functionality to D7 so it's not like we can actually test this yet. Therefore, I just fixed up the description for the setting and added a @todo comment where it's being used.

Given all that, commited and pushed.

Thanks!
-Derek