Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
So, this tested with "Expand on bullet" behavor.
Comment | File | Size | Author |
---|---|---|---|
#2 | initialize_once_avoid_expand_on_bullet_break_js_dhtml_menu.js_.patch | 1.63 KB | maxilein |
#2 | dhtml_menu_ajax.zip | 19.16 KB | maxilein |
dhtml_menu-7.x-1.0-beta1.with_ajax_load.tar_.gz | 23.25 KB | Riyuzakki | |
dhtml_menu-7.x-1.0-beta1.with_ajax_load.patch | 18.47 KB | Riyuzakki | |
Comments
Comment #1
Woodside CreditAttribution: Woodside commentedThanks for this it works well. For IE 8 there are a couple issues with the javascript file (dhtml.menu.js). Line 185 and 225 there are trailing comma's that throw errors and stop it from working. Removing those two commas fixes it for IE, and doesn't seem to break anything else (chrome, ff). L
This really helped me a lot though, site with 2800 terms the module was unusable before this update.
Comment #2
maxilein CreditAttribution: maxilein commentedThis has helped me a lot, too! I have a menu with 7000+ items which would not work before!
I experienced a break of all batch functionality using Drupal 7.16+.
DHTML-Menu had issues with "Expand on bullet" which are also in this patch above: Each page which did NOT show the menu caused an error in the js execution with an error:
... $(".menu li").css("margin-left") is undefined ...
The symptoms are described here (although for a different module..) http://drupal.org/node/1306918.
The solution to the "Expand on bullet" functionality was patched here: http://drupal.org/node/1176834#comment-5456638. It also fixes overlay (which I never used) problems: https://drupal.org/node/1130250.
I post a patch to just the js file based on this issue (dhtml_menu-7.x-1.0-beta1.with_ajax_load.patch) to correct the breaking of JS-execution and avoids initializing the menu multiple times.
I also attached my whole module as it stands now. It also contains minor css corrections. (Although the zip file is named dhtml_menu_ajax it should reside in the folder sites\all\modules\dhtml_menu).
Comment #3
maxilein CreditAttribution: maxilein commentedFor the sake of completeness: in file dhtml_menu.js
comment the lines 23 ff if you have more than one sublevel:
// if (Drupal.dhtmlMenu.init) {
// return;
// }
// else {
// Drupal.dhtmlMenu.init = true;
//}
Comment #4
maxilein CreditAttribution: maxilein commentedThe currently implemented menu seem to be affected by the latest security patches (SA-CORE-2013-002 - Drupal core - Denial of service) in D 7.20 (http://drupal.org/drupal-7.20-release-notes) and 7.21 ( http://drupal.org/drupal-7.21-release-notes)
Anybody have a fix for that?
Comment #5
vuilI set the issue's status to Needs work by the suggestion of #4.