Install suggests PHP memory limit is increased when it's already sufficient

Looks like this was caused by #1453984: Color module doesn't test for unlimited memory. when the drupal_check_memory_limit() function was added there.

Should be a simple one-line fix to that function, plus a test. (Note there are existing tests in system/Tests/Bootstrap/MiscUnitTest.php in Drupal 8.)

Probably this is a good Novice issue, actually... Adding the tag accordingly.

Attached is a patch that fixes the bug where requested memory limit == available_memory. Also, a simple test is written that tests 30MB,30MB as params asserts true.

Looks good. Also, I ran the tests locally without the fix and it failed correctly.

Looks good to me too, but maybe we need to update this code comment also, to reflect the change?

// - The memory limit is greater than the memory required for the operation.

I changed the patch. Here's the patch and an interdiff.txt. I wasn't sure what to do stylistically about the line wrapping to the next line since adding or equal to increased the line to longer than 80 cols. Take a look at what I did and let me know if it needs changed at all.

+++ b/core/includes/bootstrap.incundefined
@@ -3409,6 +3409,7 @@ function drupal_check_memory_limit($required, $memory_limit = NULL) {
+  // - The memory limit is greater than or equal to the memory required for ¶
+  // the operation.

There is a trailing space on the first line, and I believe the second line should be indented

attached is patch

Thanks! Re-RTBC.

Looks like a good bug fix, includes tests!

Committed and pushed to 8.x. Will need a re-roll for D7.

This should just be fixed correctly the first time in #1453984: Color module doesn't test for unlimited memory., as that wasn't committed yet. Thanks!