The attached patch fixes the statement and blob caching systems.

Changes made:

1. rather than create new global variables for oracle_debug, oracle_use_memcached and oracle_cache_blobs, this patch now follows Drupal convention and puts these values in the $conf array in settings.php. This means they can now be accessed by variable_get() in database.php.

2. Fixed statement caching. When looking at the code, it appears it was written to work if a 'use_caching' array key was added to your $databases array in settings.php. This has been rewritten to use the $conf['oracle_use_memcached'] variable, as well as still look at the $databases array for backwards compatibility.

3. Blob caching was completely missing, so it was added. This adds a very large performance boost in my testing.

4. The 'Settings' page was reformatted. The current settings page is displayed as a form, with 'save' and 'revert' button at the bottom. This is somewhat pointless as the only way the variables could be changed was to edit settings.php. The new formatting shows the Debug, Cache statements, and Cache Blobs settings with enabled / disabled indicators, descriptions, and instructions on how to enable them.

Would appreciate a review!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aaaristo’s picture

Good job. I'll review it as soon as i can, the first look is good to me.

brianV’s picture

Updated copy of the patch. Made a minor mistake where I could be writing NULL values to the cache (oops!).