On line 362 of maestro_engine_version1.class.php there is the following watchdog alert: watchdog('maestro',"Failed Task: {$this->_queueId}, Process: {$this->_processId} , Step Type: $this->_taskType");

This watchdog alert is getting triggered on "And Task" failures, which seems odd to me. We have an "And Task" that joins several "Interactive Function Tasks" that take a while to complete. We have our Orchestrator running once a minute, so every minute the log is getting filled with a failure message. Over the course of a few days this can effectively flush the log or a lot of useful information.

I don't think an "And Task" failure should always be triggering a watchdog alert. The only failure is just that the tasks it is anding together are not all complete yet. Seems like a lot of noise. Am I missing something simple here?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blainelang’s picture

Hi Brandon, what your suggesting makes sense.

Did you want to submit a quick patch?

bhauff’s picture

Would you like to see a conditional block the "And" type near the watchdog messages, or add some property to the Maestro Task class that defines if it should output on failures? I can whip up a patch either way you would prefer.

blainelang’s picture

I think having a task property is the best way to proceed. It may be a task property for output on failure and trace level logging. Then have a module online config option that could be enabled for detail logging (trace level).

bhauff’s picture

Hi Blaine,

Attached is a first go at a property to conditionally control watchdog logs. I am not sure about the difference between "output on failure" and "trace level logging". Also, can you clarify what you want for the module config? Do you want a checkbox added to the Maestro module config page that enables/disables all logging, or just trace level? Again, what is trace level? Sorry for so many questions, but if I can get on the same page with you I will get the patch where you want it.

Thanks!