Prevent strict warnings by consistently declaring options_form() [#1587324]

Classes that override views_content_cache_key::options_form() need to do so consistently to avoid strict warnings in PHP 5.3+

Patch to follow.

Comment	File	Size	Author
#9	1587324-9-views_content_cache-prevent_strict_warnings-D6.patch	3.42 KB	jwilson3
#9
#4	1587324-3-views_content_cache-prevent_strict_warnings.patch	3.21 KB	elliotttf
#4
#1	1587324-1-views_content_cache-prevent_strict_warnings.patch	52.16 KB	elliotttf
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

elliotttf CreditAttribution: elliotttf commented 17 May 2012 at 14:12

File	Size
1587324-1-views_content_cache-prevent_strict_warnings.patch	52.16 KB

Comment #2

elliotttf CreditAttribution: elliotttf commented 17 May 2012 at 14:12

Status:

Active

» Needs review

Updating issue status.

Comment #3

17 May 2012 at 14:13

Status:

Needs review

» Needs work

The last submitted patch, 1587324-1-views_content_cache-prevent_strict_warnings.patch, failed testing.

Comment #4

elliotttf CreditAttribution: elliotttf commented 17 May 2012 at 14:14

Status:

Needs work

» Needs review

File	Size
1587324-3-views_content_cache-prevent_strict_warnings.patch	3.21 KB

Sorry... diffed against master instead of 7.x-3.x. New patch attached.

Comment #5

Dmitriy.trt CreditAttribution: Dmitriy.trt commented 4 September 2012 at 14:59

Status:

Needs review

» Reviewed & tested by the community

Patch #4 works. Thanks, elliotttf!

We've experienced this bug on PHP 5.4, maybe it's important.

Comment #6

Steven Jones CreditAttribution: Steven Jones commented 4 September 2012 at 15:36

Status:

Reviewed & tested by the community

» Fixed

@elliotttf Thanks very much for the patch. Committed to 7.x-3.x.

Comment #7

18 September 2012 at 15:41

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #8

jwilson3

English

Ecuador

CreditAttribution: jwilson3 at Bluespark commented 3 December 2015 at 17:32

Issue summary:	View changes
Status:	Closed (fixed)	» Patch (to be ported)

This needs a Backport to Drupal 6.

The errors being reported in D6, using Views 2:

Strict warning: Declaration of views_content_cache_key_comment::options_form() should be compatible with views_content_cache_key::options_form($value, &$handler) in ctools_plugin_get_class() (line 770 of ctools/includes/plugins.inc).
Strict warning: Declaration of views_content_cache_key_node_only::options_form() should be compatible with views_content_cache_key::options_form($value, &$handler) in ctools_plugin_get_class() (line 770 of ctools/includes/plugins.inc).