When using a Views argument based on an entityref field it would be useful to be able to use the entity label in the views title using argument title substitution.

CommentFileSizeAuthor
#14 1588574.14.entityreference.entityreference.views-argument-handler-title.patch2.1 KBjoachim
#13 Screenshot30.08 KBjuves
#8 1588574.8.entityreference.entityreference.views-argument-handler-title.patch2.12 KBjoachim
#7 entref-views-arg-id.png50.06 KBjoachim
#3 1588574-2.entityreference.views-argument-handler-title.patch2.12 KBjoachim
#1 1588574.entityreference.views-argument-handler-title.patch2.09 KBjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
1588574.entityreference.views-argument-handler-title.patch2.09 KB

Here's a patch, modelled on the Views handlers for term arguments.

Status: Needs review » Needs work

The last submitted patch, 1588574.entityreference.views-argument-handler-title.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Needs review
FileSize
1588574-2.entityreference.views-argument-handler-title.patch2.12 KB

Helps if I roll against HEAD...

Changed the handler class name to be consistent with views classes already there.

joachim’s picture

joachim CreditAttribution: joachim commented

#3: 1588574-2.entityreference.views-argument-handler-title.patch queued for re-testing.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Can you explain what this does? It's fairly not obvious.

+      // Load the entity and get its label.
+      $entity = entity_object_load($value, $entity_type);

This is the menu loader function... you want entity_load_single().

joachim’s picture

joachim CreditAttribution: joachim commented

When you use a Views argument with a numeric value such as a taxonomy term tid, you can have the term's label in the title set by the argument.

Currently, with entref, you just get the ID.

joachim’s picture

joachim CreditAttribution: joachim commented
FileSize
entref-views-arg-id.png50.06 KB

This bit:

entref-views-arg-id.png

With a taxo term ref argument, %1 gets you the term label.
With an entref field, you get just the entity ID.

This patch fixes that.

joachim’s picture

joachim CreditAttribution: joachim commented
FileSize
1588574.8.entityreference.entityreference.views-argument-handler-title.patch2.12 KB

Fixed the entity loading.

rocketeerbkw’s picture

rocketeerbkw CreditAttribution: rocketeerbkw commented

#8 is working for me when referencing Nodes or Users

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented 
+++ b/views/entityreference_handler_argument_target_id.incundefined
@@ -0,0 +1,30 @@
+    foreach ($this->value as $value) {
+      // Load the entity and get its label.
+      $entity = entity_load_single($entity_type, $value);

Can't we entity_load() all entities at-once?

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Needs work

Yeah fair point.

juves’s picture

juves CreditAttribution: juves commented

That's exactly what I need, thanks!

juves’s picture

juves CreditAttribution: juves commented
FileSize
Screenshot30.08 KB

Reference field as a context filter (as summary) in view-attachment is still shown as id

Screenshot

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Needs review
FileSize
1588574.14.entityreference.entityreference.views-argument-handler-title.patch2.1 KB

Here's a patch with comment 10 addressed.

I'm not sure about comment 13. I suspect views summaries use something else in the argument handler to get the title?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

This looks good to me. Fixes an issue where the views_data_export module wasn't outputting the downloaded filename properly (entity ID instead of entity title, but with this patch, the title is properly output instead of the ID).