Negation checkbox on node type condition [#1589162]

Would be lovely to use node type conditions with negation.
Example: show title and/or navigation block on all but 1-2 node types.

Doing this "right" would mean another option in context_condition_node.inc
Here's a quick plugin to get the job done, but a real patch would be better.

Comment	File	Size	Author
#11	context-node_negate-1589162-11.patch	5.92 KB	jantoine
#11	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 38 pass, 3 fail PHP 5.4 & MySQL 5.5, D7 38 pass, 3 fail PHP 5.5 & MySQL 5.5, D7 38 pass, 3 fail PHP 5.6 & MySQL 5.5, D7 38 pass, 3 fail
#7	context_node_negate.zip	3.3 KB	doublejosh
#3	context-node_negate-1589162-3.patch	2.87 KB	grasmash
#3
#2	context-node_negate-1589162-2.patch	2.86 KB	grasmash
#2
	context_node_negate.zip	1.79 KB	doublejosh

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tr33m4n CreditAttribution: tr33m4n commented 14 June 2012 at 19:22

Subscribe, would love to see this for practically all the conditions tbh

Comment #2

grasmash CreditAttribution: grasmash commented 5 April 2014 at 17:08

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
context-node_negate-1589162-2.patch	2.86 KB

Adding option to node condition to allow negation.

Comment #3

grasmash CreditAttribution: grasmash commented 7 April 2014 at 16:41

File	Size
context-node_negate-1589162-3.patch	2.87 KB

Comment #4

doublejosh CreditAttribution: doublejosh commented 2 May 2014 at 08:08

I've been using this in production ever since the patch was posted in 2012.

Comment #5

grasmash CreditAttribution: grasmash commented 3 May 2014 at 23:18

I'm also using this in production successfully. @doublejosh, please move to RTBC if you agree that patch is reviewed, tested, and ready to be committed.

Comment #6

doublejosh CreditAttribution: doublejosh commented 15 May 2014 at 03:08

Status:

Needs review

» Reviewed & tested by the community

Done.

Comment #7

doublejosh CreditAttribution: doublejosh commented 15 May 2014 at 03:21

File	Size
context_node_negate.zip	3.3 KB

Here's a more recent version that fires more widely. Because views and other callback pages are also not that given node type.

Comment #8

doublejosh CreditAttribution: doublejosh commented 20 May 2014 at 00:48

Status:

Reviewed & tested by the community

» Needs work

I take it back, the negation code listed here is not working as intended. Should be a smart fix though.

Comment #9

grasmash CreditAttribution: grasmash commented 16 September 2014 at 13:52

@doublejosh Can you be more specific? Is the patch in #3 not working? In what way?

Comment #10

grasmash CreditAttribution: grasmash commented 10 November 2014 at 22:38

Status:

Needs work

» Needs review

I'm moving this back to 'Needs Review' because I cannot reproduce the issue referenced by @doublejosh.

Comment #11

jantoine CreditAttribution: jantoine as a volunteer commented 14 April 2016 at 06:18

File	Size
context-node_negate-1589162-11.patch	5.92 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 38 pass, 3 fail PHP 5.4 & MySQL 5.5, D7 38 pass, 3 fail PHP 5.5 & MySQL 5.5, D7 38 pass, 3 fail PHP 5.6 & MySQL 5.5, D7 38 pass, 3 fail

4 files were hidden/shown/deleted

File	Size
context_node_negate.zip	1.79 KB
context-node_negate-1589162-2.patch	2.86 KB

context-node_negate-1589162-3.patch	2.87 KB

context_node_negate.zip	3.3 KB

I was able to reproduce @doublejosh's issue by trying to have a context active on a non-node page using the negation functionality. This doesn't work is because the context_node_condition() is invoked from hook_node_view() and hook_form_alter(), so it's only fired when a node is being viewed/edited. The attached patch moves the invocation from hook_node_view() and hook_node_alter() to hook_init() where many other context conditions are invoked from.