This is a patch that allows overriding the automatically generated dependencies. See issue #1347790: Specify dependency overrides on the Automated Testing tab

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

Status: Needs review » Needs work

Could you please reroll this as a regular git patch?

In a directory that has project_dependency checked out, just do a "git diff" and that's good enough.

To apply this patch correctly first of all to do that, you can apply this one with patch -p4 -i dependency_overrides.patch

Info on creating patches for any project is on the "Version control" tab of the project, in this case, http://drupal.org/project/project_dependency/git-instructions. There's more at http://drupal.org/node/707484.

Thanks, and sorry for the trouble, but it will be good to get you making regular git patches that can be applied and tested. Feel free to ping me if I can help.

rfay’s picture

First, thanks for all your work on this, and for your comaintainership of this neglected but important module.

I didn't find any screaming issues in a simple review, but trying it out the UI needs a bit of work.

1. The form is not wrapping right, so is pretty ugly.
2. The use of "Project #1" etc. is going to be confusing in this context.

Overall, I think the current UI will add too much confusion to the "add branch" thing. I think it should be in its own form somehow, and something that ordinary people would not have to interact with.

In addition, I notice you're using raw JS to populate a form. It would be far better to use AHAH here, IMO. AHAH works directly with the form API; nearly every intervention with FAPI using javascript ends up causing pain.

project_dependency_extra_depdendencies.jpg

trobey’s picture

Here is an updated patch. This changes the wording and fixes the line wrap problems. AHAH is used and the only thing the Javascript code does is hide the button for retrieving the versions when users have Javascript enabled (graceful degradation) and invoke AHAH when the name of a dependency is entered to retrieve the versions for that project.

trobey’s picture

Status: Needs work » Needs review
rfay’s picture

I'm sad that I haven't reviewed this, but am reluctant to make changes when the D7 port is going to be coming up quite soon, according to projections...

rcross’s picture

is this still on hold? or would a re-roll be helpful?

rfay’s picture

@rcross sure a review + reroll would be great. But please plan to make sure it works for D7 as well... Yay!

hass’s picture

Issue summary: View changes
trobey’s picture

It is not a duplicate. It is a GUI interface for specifying dependencies to be used when the automatic generation failed due to ambiguity or bugs. This also allowed testing against different versions to aid developers in easily determining which versions of dependencies worked so that they could specify the range of versions in their dependencies. Versions are not used in dependencies as often as they should be and a big reason is it is such a pain to manually download and test each version. Since all the versions are stored on drupal.org this would seem to be a much easier way to test against different versions. But since no one reviewed the patch before drupal.org was ported from Drupal 6 to Drupal 7 this has been lost. I am not inclined to spend time again writing this for Drupal 7 because I do not have any time to waste.