Select type AHAH form doesn't return any answer

I get the same thing with 6.x-2.4

I select Image Ad, and then go to upload an image file. When I click attache, the page refreshes with no image.

I suspect that this issue may relate to the issues submitted on May 15th. Here is the log of changes from the release notes:

May 15th, 2012 (6.x-2.3)
- bug #797274 by tacituseu: apply modified version of tacituseu's patch to get charts to appear
- bug #1252536 by osopolar: fix iframe scrolling options
- Clean up AHAH selection of type
- Require a debug key to show debugging information

I worry that the clean up AHAH selection of type may have inadvertantly broken something. In my experience, "Cleaning" of code often leads to unintentional problems. I will diff the code and see if there is anything obvious.

I found that the ad type select pull-down was consolidated with the Select button that was available on previous versions. My theory is that this prevents the reload of the page on selection, and relys on Javascript to update the menu. I don't see any reason for using AHAH in an ad creation page, and prefer not to have core functionality for form operation to require Javascript.

For the time being, I am going to revert to a previous revision as I don't have time to dig deeper into the code for a solution.

I'm not able to reproduce it on a test VM running Ubuntu 12.04 + PHP 5.3 (5.3.10-1ubuntu3.1, to be precise) + MySQL 5.5 + Drupal 6.26.

I'm assuming you've already tried clearing caches, both browser and Drupal. Is there anything in watchdog log?

Oh, and which Ad modules do you have enabled?

Has anyone else got any idea on this? Since the last update we are having the same problems...

I finally added some new HTML ads today by going through the normal process - selecting HTML from ad type (nothing happened at time) went on to publish and save and it went straight back into the same screen but this time the section to input the HTML was showing. So inserted code and saved again. Worked perfectly and ads now created and active :-)

I can confirm that we have this problem also.
When I select an ad type nothing happens and Chrome reports the following

--------------
Uncaught TypeError: undefined is not a function
onload
o.fn.o.append js_c937ae2ddf41dd033df1bbe95b8df6c3.js:12
o.fn.o.domManip js_c937ae2ddf41dd033df1bbe95b8df6c3.js:12
o.fn.o.append js_c937ae2ddf41dd033df1bbe95b8df6c3.js:12
o.each.o.fn.(anonymous function) js_c937ae2ddf41dd033df1bbe95b8df6c3.js:12
r
--------------
Looking at the script source for the above JS file it's the jquery line - the packed jquery oneliner

Also, I get this error:
"Resource interpreted as Document but transferred with MIME type text/javascript: "http://myhost.mydomain.com/node/add/ad/ahah"."

The contents of this url are "{"status":true,"data":null}" and the mime is text/javascript. Looks like perfectly valid json to me

Tried downgrading to 6.x-2.3 - the error remains
Tried running the 6.x-2.x dev release - error remains

We're running pressflow 6.20, php is PHP 5.2.6-1+lenny16 with Suhosin-Patch 0.9.6.2 (cli) (built: Feb 3 2012 13:17:21)

I remember seeing a similar ahah error before but with imagefield uploads and in that case it was a Memcache related error solved by disabling memcache.
I'm going to try this and report back.

Edit: Nope, disabling memcache didn't fix it.

In 6.x-2.2 it's actually working so we downgraded.
One thing that strikes me is that in 6.x-2.3 and up the "select" button is removed from the ad type form and the form seems to be auto-submitted with JS. From 6.x-2.3 the ad type form is not working so maybe look into that area?

I'm seeing the same error and I haven't been able to get to the bottom of it. For some reason downgrading to 6.x-2.2 didn't fix the problem for me, though perhaps I need to be more aggressive with clearing caches after downgrading.

From my debugging, it looks like $_POST['adtype_select'] is empty inside ad_form_ahah() - why would this be?

As driftyfluff says in #9, this error doesn't prevent you from creating the ads, but it's confusing and inconvenient to get the error every time!

For what it's worth:
Downgrading worked for me AFTER I fixed line 211 in the ad_flash.module file (see http://drupal.org/node/821270)
I then got to playing around and simply copied the adtype select from ad => 2.2 to the current version - line 638.
Worked like a charm.
Dunno if this will help anyone, but I thought I would throw it out there.

EDIT: It seems that when using AHAH, the calling element is removed from the form submission: (http://drupal.org/node/1197142#comment-4643222) So that's why the button is still required. Someone with a more in-depth knowledge of AHAH would have to confirm this.

I can confirm backing out the change in commit to ad.module in http://drupal.org/commitlog/commit/2482/a8126de81dab1116bf9c049cfbc70833... as mentioned at #13 fixes this for me with Firefox

Please refer to the original post in this thread. I know the work-around that some are using, but it is still a bug that should be fixed.

We use a static server for images, so I always use the remote image option, selected on the settings page.

When setting up a new advertismenet, I select "Image ad" from the select ad type pull-down. I observe a little javascript loading icon, but nothing else happens. I cannot enter the remote ad URL as that part of the form does not appear.

I am forced to upload an image and save the ad. Then edit the ad node, and then add the remote URL to the ad image on our static server.

Please help as I want to update to the latest to take advantage of the security fixes.

Thanks!

I can confirm it's not working. It can even get very troublesome if a field is required in the AHAH response, thus preventing to save the ad.

Restoring the Select button fixes it as explained in #13 and #14. Can't submit a patch as I'm running a customized 2.4 version.
But here is the importing hunk to restore in function ad_form(&$node, &$form_state)

    $form['select']['adtype_select'] = array(
      '#type' => 'select',
      '#required' => TRUE,
      '#options' => $adtypes,
      '#default_value' => isset($node->adtype_select) ? $node->adtype_select : '',
    );
    $form['select']['adtype_submit'] = array(
      '#type' => 'submit',
      '#value' => t('Select'),
      '#validate' => array('ad_select_adtype'),
      '#ahah' => array(
        'path' => 'node/add/ad/ahah',
        'wrapper' => 'adtype-ahah-wrapper',
        'effect' => 'slide',
      ),
    );  

Here's a patch adapted from http://drupal.org/node/1197142#comment-6216256

thank you fizk, your patch works well on firefox, but the problem remains on IE9 witch still wants to download the ahah response.

The in #17 works, but it needed to be rerolled. Thanks fizk!

As mentioned in #19, fizk's patch worked but just needed to be rerolled, so marking this as RTBC.

Thanks Damien! Committed to 6.x-3.x.

http://drupalcode.org/project/ad.git/commit/bfa02a7fee62294085926eb17871...

I'm sorry to reopen the issue
the patch in #19 solves the problem for me on firefox and chrome but not on IE10 which still proposes me to download the json file.