Closed (fixed)
Project:
Project issue tracking
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 May 2012 at 03:30 UTC
Updated:
11 Jul 2012 at 17:42 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwActually, Ian isn't going to have any time to work on this in the near future, so this is available if someone else wants to claim it. Or, he'll claim it back if he's going to start on a patch.
Comment #2
iamcarrico commentedHey! Guess what? I have more time... so I will get working on this.
Comment #3
iamcarrico commentedI want to put a staples button on this post... "That was easy".
Although I generally disagree with having a sole settings option for determining if a node is related to the project module solely off of the variable, this will work as it is requested. Personally, I think it should be based on if fields are present... much like the og module.
Comment #4
dwwThanks. However, please read the original post and handle all the things I spelled out there. This only implements the hook and touches one place that was referring to the old setting. We still need to remove the old checkbox entirely, fix project_issue_issue_node_types(), etc, etc.
Comment #5
iamcarrico commentedAh, I assumed that all the settings went through the pre-made function to check if a project is an issue. It seems only project_issue_issue_node_types() was the only rogue function, the rest go through project_issue_node_type_is_issue(). The checkbox was already removed.
Comment #6
dwwYeah, grep is your friend. ;) But yeah, good move to just have all those helpers go through the same place. I already fixed that in project and project_release, but I didn't want to touch that here so it wouldn't conflict.
The checkbox itself was gone, but the submit handler was still around. Thanks for removing that, too.
#5 included a syntax error:
but I just fixed that locally before pushing.
Committed and pushed to 7.x-2.x.
Thanks!
-Derek
Comment #7
senpai commentedTagging for Sprint 4.
Comment #8
damien tournoud commentedI guess the
project_behavior_project_issuevariable now needs to be set somewhere.Comment #9
dwwThat's set by core. @see node_type_form_submit().
Comment #10
damien tournoud commentedExcept that it is not for the
project_issuenode type created during the installation.Comment #11
dwwYes, I just realized that's what you were talking about and came to commit something like this. ;)
After the patch:
Committed 7781943 and pushed to 7.x-2.x.
Thanks!
-Derek
Comment #13
iamcarrico commented