why do you enclose integers with quotes. As i know this is not required. Code looks like variable_get('admin_theme', '0') == '0', should look like variable_get('admin_theme', 0) == 0 as i know.

Comments

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Active » Closed (works as designed)

The variable_get('theme_settings_admin_theme', '1') mirrors the code style found in Drupal 6's system_admin_theme_settings().

Since I want ThemeSettingsAPI 2.x to be easily ported to Drupal core, I want to keep the code style similar to core.

Besides the style, there’s no other issue. Correct?

hass’s picture

hass CreditAttribution: hass commented
Status: Closed (works as designed) » Active

Looks like you found a code style bug in core :-). Search core for variable_get and integers. All are unquoted...

Haven't found other issues yet, but i have only tested the "view" mode :-). I'm currently updateting the themes...

hass’s picture

hass CreditAttribution: hass commented

fyi: http://drupal.org/node/160207

hass’s picture

hass CreditAttribution: hass commented
Status: Active » Closed (fixed)

looks like it doesn't matter... so closing