On UC checkout page by chose Card payment metod appears: What is CCV? help button, witch pops-up a window of detais without appropriate character encoding.

Please modify the certain line to insert: charset=utf-8,

? ubercart/payment/uc_credit
Index: ubercart/payment/uc_credit/uc_credit.theme.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/ubercart/payment/uc_credit/uc_credit.theme.inc,v
diff -u -p -r1.0 uc_credit.theme.inc
--- ubercart/payment/uc_credit/uc_credit.theme.inc 25 Apr 2012 19:23:58 -0000 1.0
+++ ubercart/payment/uc_credit/uc_credit.theme.inc 27 May 2012 12:00:00 -0000
@@ -15,2 +15,2 @@
-   'onclick' => "window.open(this.href, 'CVV_Info', 'toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=1,width=480,height=460'); return false;",
?>
+   'onclick' => "window.open(this.href, 'CVV_Info', 'charset=utf-8, toolbar=0, scrollbars=1, location=0, statusbar=0, menubar=0, resizable=1, width=480, height=460'); return false;",
?>
Files: 
CommentFileSizeAuthor
#5 1602202-html5-cvv-popup.patch1.33 KBlongwave
PASSED: [[SimpleTest]]: [MySQL] 2,727 pass(es).
[ View ]
#1 uc_credit.theme.inc.patch818 bytesBenwick
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ubercart-DRUPAL-7--uc_credit.theme_.inc_.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Issue summary:View changes

formatting

Issue summary:View changes

only text formatting

Issue summary:View changes

patch like text formatting

Status:Needs work» Needs review
StatusFileSize
new818 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ubercart-DRUPAL-7--uc_credit.theme_.inc_.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

i'm composed this patch for it.

Status:Needs review» Needs work

The last submitted patch, ubercart-DRUPAL-7--uc_credit.theme_.inc_.patch, failed testing.

Status:Needs work» Postponed (maintainer needs more info)

Why is this needed? In Firefox the popup is already detected as UTF-8. I also can't find any reference that says window.open() accepts "charset" in the third parameter.

Status:Postponed (maintainer needs more info)» Needs review

I don't know exactly, perhaps it's an tpl issue, but with it works as i need.

Version:7.x-3.1» 7.x-3.x-dev
StatusFileSize
new1.33 KB
PASSED: [[SimpleTest]]: [MySQL] 2,727 pass(es).
[ View ]

Can you test this alternative patch? This adds a doctype and full HTML wrapper around the CVV popup, including the UTF-8 charset meta tag.

Status:Needs review» Fixed

Committed a slightly modified version of #5 that means the HTML on this popup finally validates.

http://drupalcode.org/project/ubercart.git/commit/bf6d332

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

patchlike text formatting 2