I get this warning when viewing any group. I've enabled three blocks... content links, OG extra members, and group details.

Strict warning: Only variables should be passed by reference in og_extras_subscribe() (line 52 of ~/sites/all/modules/og_extras/og_extras.module).

I'm using the current dev version of og and entityreference on drupal 7.14.

CommentFileSizeAuthor
#1 og_extras-1605386.patch712 bytesLes Lim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Les Lim’s picture

Les Lim
he/they
Primary language English
CreditAttribution: Les Lim commented
Title: Strict warning issue(possible security risk?) » Strict warning: Only variables should be passed by reference
Status: Active » Needs review
FileSize
og_extras-1605386.patch712 bytes

No reason to expect this to be a security issue. Rather, you can't put a function wherever a variable reference is expected instead, as is the case with drupal_render().

Fix attached.

David Lesieur’s picture

David Lesieur CreditAttribution: David Lesieur commented
Status: Needs review » Reviewed & tested by the community

Works for me, and code looks good.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
CreditAttribution: eojthebrave commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

http://drupal.org/commitlog/commit/38132/15409a4d5837bf6b5b4250417a962f3...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

update info