Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
replace all the drupal_add_js calls with a single add_library call.
replace all the drupal_add_js calls with a single add_library call.
Comments
Comment #1
ericduran CreditAttribution: ericduran commentedComment #2
blakehall CreditAttribution: blakehall commentedWorks here.
Comment #3
ericduran CreditAttribution: ericduran commentedI screwed up some docs. Here's another patch on top of this one.
Comment #4
ericduran CreditAttribution: ericduran commentedMoves the css out of the library, because apparently it still works with out any of the JS
Comment #5
levialliance CreditAttribution: levialliance commentedThe 3rd parameter of drupal_add_library(), $every_page can be TRUE since variable_get('nice_menus_js', 1) is a global setting.
Comment #6
xiukun.zhou CreditAttribution: xiukun.zhou commentedThanks a lot to ericduran, levialliance and everyone else for the great work on the patches, testing, reviews and reporting.
It's more time this got committed and I went ahead and had this rolled at: 7.x-2.x: b17c01b.
Marking this as fixed.
Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.
Cheers!