Hello,

In addition to the Google+1 and Facebook Like button, this patch has extra support for more native services. See list:

Facebook Recommend
Facebook Send
Facebook Subscribe
Foursquare Save
Foursquare Follow
Pinterest Follow
Youtube Subscribe
Twitter Follow

Feel free to check it out.

Thanks.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

radiobuzzer’s picture

Issue summary: View changes

Hi, this is indeed interesting because these widgets are already available in the "embed code" version of sharethis. I will try to review when I have time. Has there been any change since then?

navneet0693’s picture

Status: Needs review » Needs work
  1. +++ b/ShareThisForm.css
    @@ -241,4 +241,13 @@
    \ No newline at end of file
    

    New Line error

  2. +++ b/ShareThisForm.css
    @@ -241,4 +241,13 @@
    +	padding-bottom: 5px !important;
    

    Spacing issues.

  3. +++ b/sharethis.module
    @@ -398,6 +490,24 @@ function sharethis_get_button_HTML($data_options, $mPath, $mTitle) {
    +      $attributes['st_username']=variable_get('sharethis_option_extras_fbsub_field', ''); ¶
    

    Spacing issues.

navneet0693’s picture

yogeshmpawar’s picture

  1. +++ b/ShareThisForm.css
    @@ -243,6 +243,15 @@
    +	margin-bottom: 0px !important;
    

    white space issues

  2. +++ b/ShareThisForm.css
    @@ -243,6 +243,15 @@
    +	padding-bottom: 5px !important;
    ...
     st_cns_container {
    

    missing .(dot)

navneet0693’s picture

Status: Needs work » Needs review
FileSize
7.67 KB

Status: Needs review » Needs work

The last submitted patch, 5: added_native_services-1611844-5.patch, failed testing.

navneet0693’s picture

Status: Needs work » Needs review
FileSize
7.68 KB

Status: Needs review » Needs work

The last submitted patch, 7: added_native_services-1611844-6.patch, failed testing.

yogeshmpawar’s picture

Status: Needs work » Reviewed & tested by the community

Tested the patch, it's working fine.

The last submitted patch, NativeServiceSupport.patch, failed testing.

The last submitted patch, 3: added_native_services-1611844-3.patch, failed testing.

purushotam.rai’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

purushotam.rai’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.